Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flyout placement for versions <RS5 #2676

Merged
merged 266 commits into from
Jun 26, 2019
Merged

Fix Flyout placement for versions <RS5 #2676

merged 266 commits into from
Jun 26, 2019

Conversation

khetanashita
Copy link
Contributor

@khetanashita khetanashita commented Jun 25, 2019 •
edited by ghost
Loading

Some options for flyout placement were added in RS5 (like FlyoutPlacementMode::BottomEdgeAlignedLeft, TopEdgeAlignedLeft and LeftEdgeAlignedTop).

Adding a check to avoid failure for <RS5 devices.

Microsoft Reviewers: Open in CodeFlow

Office VSTS Default Agent and others added 30 commits June 11, 2019 18:22
@khetanashita
Applying package update to 0.58.0-vnext.65
f89a8d8
@PPatBoyd @khetanashita
add layoutanimationtests to cmake unit tests (#2372)
13cf2d5
@khetanashita
Applying package update to 0.58.0-vnext.66
cd32e71
@acoates-ms @khetanashita
Update to [email protected] (#2370)
9ea57ab
@licanhua @khetanashita
Fix first launch and reload/unload crash (#2373)
f16c47c 
* Fix first launch and reload/unload issue

* Reword the error message

* rename the helper to wrapper

* PrepareJavaScriptRuntime from 750ms to 5s

* use shared_from_this

* remove ThisWrapper

* ReactControl in rt to shared_ptr
@khetanashita
Applying package update to 0.58.0-vnext.67
4db7427
@acoates-ms @khetanashita
Update to [email protected] (#2395)
1cac309
@acoates-ms @khetanashita
Update version of ChakraCore in sample (#2398)
f562376
@khetanashita
Applying package update to 0.58.0-vnext.68
1d4e2b6
@rozele @khetanashita
chore(NPM): Updates JS modules to match RN 0.58 (#2293)
b79e34a 
A few deprecations and refactorings caused issues with the upgrade to 0.58. This was all the changes to JS necessary to get RNTester working.
@khetanashita
Applying package update to 0.58.0-vnext.69
06bdcc8
@jonthysell @khetanashita
Moved .ado to root (#2406)
6c1c478
@harinikmsft @khetanashita
Renamed RNWCPP to vnext and RNWCS to current (#2405)
9ed51be 
* Refactored root folders
* Updated path references
* Fixed appveyor.yml
@jonthysell @khetanashita
Update CODEOWNERS and ISSUE_TEMPLATE (#2408)
6945836 
* Update CODEOWNERS
* Remove old ISSUE_TEMPLATES
@harinikmsft @khetanashita
Committing changes to master readme (#2409)
337ee4f 
* Committing changes to master readme

* Updating to address review feedback
@acoates-ms @khetanashita
Update publish logic
8831350
@acoates-ms @khetanashita
More publish logic fixes
a0e245e
@khetanashita
Applying package update to 0.58.0-vnext.70
c731a2b
@acoates-ms @khetanashita
Update evergreen logic
7bbbe42
@hansenyy @khetanashita
Remove ChakraCoreShim project. (#2407)
a1fe499
@khetanashita
Applying package update to 0.58.0-vnext.71
730f314
@JunielKatarn @khetanashita
Enable WebSocket resource unit tests. (#2415)
d473d14 
* Define test WebSocket types.

* Use CRLF for C++ files.

* Try basic_stream_socket over IWebSocketStream.

* Use boost::beast::test::stream.

* Defined async_connect(test::stream& ...

* Move custom async_connect into WebSocket.cpp.

* Defined MockStreamLayer subtype.

* Use errc::make_error_code.

* Define MockStream, equivalent to websocket::stream

* Implement async read and write in MockStreamLayer.

* Override boost::beast::http::async_read and write.

* Move TestWebSocket implementation to CPP file.

* Stop including <boost/beast/experimental/test/stream.hpp>.

* Simplify template decls for SecureWebSocket.

* Simplified WebSocket template declaration.

* Updated namespace for WebSocket-related APIs.

* Reset default platform to x64 in SLN.

* Re-located BaseWebSocketTest.
@khetanashita
Applying package update to 0.58.0-vnext.72
d7cd525
@JunielKatarn @khetanashita
End of line updates. (#2418)
c469a64 
* End of line updates for inconsistent CPP files.

* Fixed symbol typo.
@khetanashita
Applying package update to 0.58.0-vnext.73
f8d211b
@harinikmsft @khetanashita
README for current (#2422)
2b48e38 
* Committing a new readme file for "current" and making updates to main readme, vnext readme and other files to reflect the same

* Updated releases link
@khetanashita
Applying package update to 0.58.0-vnext.74
b0a060b
@harinikmsft @khetanashita
Minor updates to readme (#2423)
c5fc651 
* Minor updates to readme

* Update README.md

* Update README.md
@harinikmsft @khetanashita
Updating Getting Started (vnext) (#2425)
13cf6d1 
* Adding manual install steps and steps for running sample apps through cloning repo.

* Updated sdk version

* Update vnext/docs/GettingStarted.md

Co-Authored-By: harinikmsft <[email protected]>

* Update vnext/docs/GettingStarted.md

Co-Authored-By: harinikmsft <[email protected]>
@khetanashita
Applying package update to 0.58.0-vnext.75
924aade
acoates-ms and others added 15 commits June 11, 2019 18:22
@acoates-ms @khetanashita
Remove nmake build files (#2595)
1d23332
@ahimberg @khetanashita
Fix include (#2596)
4243fd4
@khetanashita
Applying package update to 0.58.0-vnext.167
8c36f51
@acoates-ms @khetanashita
Fix publish script
b0888da
@khetanashita
Applying package update to 0.58.0-vnext.168
258ee32
@licanhua @khetanashita
Update target version to 19h1 and set XamlRoot for Flyout (#2456)
da71ae2 
* draft

* workaround cppwinrt error

* popup fix

* rollback change to popup and update Flyout

* update comment from popup to flyout

* change signature and rename getShadowNodeWithXamlRoot

* draft

* workaround cppwinrt error

* popup fix

* rollback change to popup and update Flyout

* update comment from popup to flyout

* change signature and rename getShadowNodeWithXamlRoot

* install SDK

* install SDK for win32

* install desktopcpp
@khetanashita
Applying package update to 0.58.0-vnext.169
a9b326f
@acoates-ms @khetanashita
Update to [email protected] (#2600)
305b1f2
@jonthysell @khetanashita
Implemented accessibilityLiveRegion (#2591)
9cc0219 
* Add accessibilityLiveRegion property to FrameworkElementViewManager
* Added AccessibilityUtils.h with helper method to announce the LiveRegion change
* Fixed bug and added example in RNTester
@khetanashita
Applying package update to 0.58.0-vnext.170
2bcc778
@khetanashita
Merge remote-tracking branch 'upstream/master'
720818c
@khetanashita
Add flyout offset props
2106f12
@khetanashita
Took care of review comments
affd00e
@khetanashita
merge with master
5f8fcc7
@khetanashita
flyout RS4 crash fix
c025fff
@khetanashita khetanashita requested a review from a team as a code owner June 25, 2019 16:54
@ghost ghost added the vnext label Jun 25, 2019
@chrisglein
Copy link
Member

What's going on with the commit history of this PR? (264 commits)

@ahimberg
Copy link
Member

What's going on with the commit history of this PR? (264 commits)

This seems to happen with people that submit a pull request from their fork/master instead of making a branch in their repo. But yeah because of 264 commits you can't use codeflow to review the changes

@chrisglein
Copy link
Member

What's going on with the commit history of this PR? (264 commits)

This seems to happen with people that submit a pull request from their fork/master instead of making a branch in their repo. But yeah because of 264 commits you can't use codeflow to review the changes

Ah, that explains it. Good candidate for something to add to a contribution guide (it's mentioned in react-native's here, CoreCLR's here, and WinUI's here

@khetanashita
Copy link
Contributor Author

What's going on with the commit history of this PR? (264 commits)
This seems to happen with people that submit a pull request from their fork/master instead of making a branch in their repo. But yeah because of 264 commits you can't use codeflow to review the changes

Ah, that explains it. Good candidate for something to add to a contribution guide (it's mentioned in react-native's here, CoreCLR's here, and WinUI's here

My bad. I'll make sure to work off of a dedicated branch rather than master.

ahimberg
ahimberg approved these changes Jun 26, 2019
View reviewed changes
vnext/ReactUWP/Views/FlyoutViewManager.cpp Outdated Show resolved Hide resolved
@khetanashita khetanashita merged commit 43db5b7 into microsoft:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisglein chrisglein chrisglein approved these changes

@ahimberg ahimberg ahimberg approved these changes

Assignees

@ahimberg ahimberg

@a00889920 a00889920

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.