Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accessibility fixes for <View> #2612

Merged
merged 1 commit into from
Jun 14, 2019
Merged

accessibility fixes for <View> #2612

merged 1 commit into from
Jun 14, 2019

Conversation

ahimberg
Copy link
Member

@ahimberg ahimberg commented Jun 13, 2019 •
edited by ghost
Loading

This fixes a few issues we noticed getting People card to production where there was duplicated info in the tree, and help text not in the right place. Fixes 3 things:

  1. When transferring, clear the old properties. In the case of View converting itself to a Control, the 'oldView' continues to exist but has been wrapped by a contentcontrol. leaving the accessibilityname, etc meant it was set on 2 elements in the tree
  2. HelpText not getting transferred
  3. make the old view not accessible after transfer. (Create ReactContentBaseMSModule Extensions #1 is not really necessary with this change)
Microsoft Reviewers: Open in CodeFlow

@ahimberg ahimberg added the vnext label Jun 13, 2019
@ahimberg ahimberg requested a review from a team as a code owner June 13, 2019 23:44
kmelmon
kmelmon approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ahimberg ahimberg merged commit 6b27800 into microsoft:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmelmon kmelmon kmelmon approved these changes

@jonthysell jonthysell Awaiting requested review from jonthysell

@randy-flynn randy-flynn Awaiting requested review from randy-flynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahimberg @kmelmon