-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider #14332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
jonthysell
approved these changes
Feb 3, 2025
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
Show resolved
Hide resolved
JesseCol
reviewed
Feb 4, 2025
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Outdated
Show resolved
Hide resolved
JesseCol
reviewed
Feb 4, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionDynamicAutomationProvider.cpp
Outdated
Show resolved
Hide resolved
JesseCol
reviewed
Feb 4, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionTextProvider.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Accessibility
Area: Text
Area: TextInput
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Bring new architecture to compliant accessibility standards.
Resolves #13349
Resolves #13350
What
Note: Many methods/scenarios have not been implemented yet. Waiting for AccessibilityGrading to see what additional implementation is needed. #14333
Testing
Local testing and additional test infrastructure added to support dumping text information.
Changelog
Should this change be included in the release notes: Yes
Add support for ITextProvider, ITextProvider2, and ITextRangeProvider. App users now have access to detailed text information from UIA tools.