Fix react devtools hitting an assert on launch #14320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Debug Infrastructure
Area: Paper
Old Architecture
acoates-ms
approved these changes
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
to TatianaKapos/react-native-windows
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
that referenced
this pull request
Jan 31, 2025
TatianaKapos
added a commit
that referenced
this pull request
Feb 1, 2025
TatianaKapos
added a commit
that referenced
this pull request
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary call to Super::DispatchCommand, ViewManagerBase will just assert(false) on dispatch command. https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Views/ViewManagerBase.cpp#L358. Seemed better just to remove the call incase Meta adds more methods we aren't supporting on Paper.
But let me know if the call is necessary for some reason I'm missing, we could also add a check to ignore the unsupported methods (see previous commit).
Type of Change
Why
react dev-tools will fail because upstream added the methods "highlightTraceUpdates", "highlightElements", and "clearElementsHighlights" and we only added those for Fabric, not Paper.
Resolves #14298
Testing
tested that react devtools works again!
Changelog
yes - Fixes react devtools hitting an assert on launch
Microsoft Reviewers: Open in CodeFlow