Round Focus visuals by default, fix nudge rendering #14312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yajur-Grover
approved these changes
Jan 29, 2025
jonthysell
approved these changes
Jan 29, 2025
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Jan 29, 2025
* Round Focus visuals by default, fix nudge rendering * Change files
acoates-ms
added a commit
that referenced
this pull request
Jan 31, 2025
… factor (#14318) * Fix crash when currently focused element gets marked as enableFocusRing=false (#14306) * Fix crash when currently focused element gets marked as enableFocusRing=false * Change files * [Fabric] Use PopupWindowSiteBridge for Modal when USE_EXPERIMENTAL_WINUI3 is true (#14284) * add modal implementation with PopupWindowSiteBridge * Change files * add conditional * feedback * Initial support for UIA and tab navigation for a child Island (#14305) * Basic support for stitching the UIA tree for a ContentIslandComponentView's child * Updated comment * Change files * Support shift+tab, and move Automation event handlers to ContentIslandComponentView * Allow portals to have independent layout constraints and scale factor (#14315) * Allow portals to have independent layout constraints and scale factor * format * change files * fix * Round Focus visuals by default, fix nudge rendering (#14312) * Round Focus visuals by default, fix nudge rendering * Change files * change files * fix * fix * fix --------- Co-authored-by: Tatiana Kapos <[email protected]> Co-authored-by: JesseCol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Round focus visuals by default to align with fluent design.
Fix issue when the focus visual was nudged to fit into the container, which would cause the inner and outer focus visuals to overlap causing a muddy gray border on the nudged sides.
Screenshots
Before:
No rounded focus by default: (and bad bottom edge due to nudging)
Messed up focus visuals when focus visual nudged: (Visual is nudged on top three sides to fit inside a scrollviewer)
After:
Rounded focus visual:
Fixed nudged focus visual: (Visual is nudged on top three sides to fit inside a scrollviewer)
Microsoft Reviewers: Open in CodeFlow