Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate RN Nightly Build 0.78.0-nightly-20250113-d4407d6f7 #14278

Merged
merged 22 commits into from
Jan 23, 2025
Merged

Integrate RN Nightly Build 0.78.0-nightly-20250113-d4407d6f7 #14278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bc6658e
Initial integrate
Yajur-Grover Jan 14, 2025
b43ffa6
fix tester examples and add support for new codegen type
Yajur-Grover Jan 14, 2025
d8e64c8
Change files
Yajur-Grover Jan 14, 2025
b367e32
fix change file
Yajur-Grover Jan 14, 2025
d44d744
fix shadownode and add to shared
Yajur-Grover Jan 15, 2025
0ed5f92
add override
Yajur-Grover Jan 15, 2025
2b3617f
fix error in example
Yajur-Grover Jan 15, 2025
aac987d
fix linting
Yajur-Grover Jan 15, 2025
c55f3dd
revert postinstall removal
Yajur-Grover Jan 15, 2025
cc69189
Merge branch 'main' into yg-int-1-13
Yajur-Grover Jan 16, 2025
fbe6ffd
fix bad import
Yajur-Grover Jan 16, 2025
640fca5
Merge branch 'yg-int-1-13' of https://github.com/Yajur-Grover/react-n…
Yajur-Grover Jan 16, 2025
848b885
fix to e2etest app
Yajur-Grover Jan 16, 2025
7c9e9dc
fix broken import
Yajur-Grover Jan 17, 2025
a3a779c
fix linting and remove second image network callback test
Yajur-Grover Jan 17, 2025
3ca43cc
revert RNTesterText to Text
Yajur-Grover Jan 17, 2025
7052c53
update fabric snapshots and fix textinput example
Yajur-Grover Jan 17, 2025
a37d031
fix textinputsharedexamples
Yajur-Grover Jan 17, 2025
86917eb
update snapshots
Yajur-Grover Jan 21, 2025
6c69754
remove unused method
Yajur-Grover Jan 22, 2025
2e1414c
Merge branch 'main' into yg-int-1-13
Yajur-Grover Jan 22, 2025
b34f68d
Merge branch 'main' into yg-int-1-13
Yajur-Grover Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-iss/react-native-win32/src-win/Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

'use strict';

// $FlowFixMe[cannot-resolve-module]
import typeof DrawerLayoutAndroid from './DrawerLayoutAndroid.android';

module.exports =
Expand Down
8 changes: 6 additions & 2 deletions packages/@react-native-windows/tester/src/js/examples/Text/TextExample.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,9 @@ function ContainerBackgroundColorExample(props: {}): React.Node {
function TextDecorationExample(props: {}): React.Node {
return (
<>
<RNTesterText style={{textDecorationLine: 'underline'}} testID={'text-decoration-underline'}>
<RNTesterText
style={{textDecorationLine: 'underline'}}
testID={'text-decoration-underline'}>
Solid underline
</RNTesterText>
<RNTesterText style={{textDecorationLine: 'none'}}>
Expand Down Expand Up @@ -667,7 +669,9 @@ function TextDecorationExample(props: {}): React.Node {
function NestedExample(props: {}): React.Node {
return (
<>
<RNTesterText onPress={() => console.log('1st')} testID={'text-outer-color'}>
<RNTesterText
onPress={() => console.log('1st')}
testID={'text-outer-color'}>
(Normal text,
<Text style={{color: 'red', fontWeight: 'bold'}}>
(R)red
Expand Down
2 changes: 1 addition & 1 deletion packages/@react-native-windows/tester/src/js/examples/TextInput/TextInputExample.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function AutogrowingTextInputExample({
});
}}
{...props}
testID={"textinput-autogrow"}
testID={'textinput-autogrow'}
/>
<RNTesterText>Plain text value representation:</RNTesterText>
<RNTesterText>{text}</RNTesterText>
Expand Down
6 changes: 0 additions & 6 deletions packages/e2e-test-app-fabric/test/ImageComponentTest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ describe('Image Tests', () => {
const dump = await dumpVisualTree('image-network-callback');
expect(dump).toMatchSnapshot();
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chiaramooney Just want to confirm that it's good to remove this test - in this PR upstream, the Image component attached to this test was removed: facebook/react-native#48619. Since there's is only one image left in this example, I removed the test for the second (now deleted) image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that's okay!

test('An Image component can hve a network callback 2', async () => {
const component = await app.findElementByTestID('image-network-callback-2');
await component.waitForDisplayed({timeout: 5000});
const dump = await dumpVisualTree('image-network-callback-2');
expect(dump).toMatchSnapshot();
});
test('A network Image example', async () => {
const component = await app.findElementByTestID('image-network');
await component.waitForDisplayed({timeout: 5000});
Expand Down
Loading