Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forked WebDriverIO or newer version of WinAppDriver for E2E testing #3019

Closed
licanhua opened this issue Aug 27, 2019 · 6 comments
Closed

Use forked WebDriverIO or newer version of WinAppDriver for E2E testing #3019

licanhua opened this issue Aug 27, 2019 · 6 comments
Assignees
@kmelmon
Labels
Area: Test Infrastructure enhancement
Milestone
Backlog

Comments

@licanhua
Copy link
Contributor

PR 4369 described the problem between WinAppDriver and WebDriverIO.
I always created PR on WinAppDriver to fix the problem, but still no ETA to release it.
Possible adopt the newest WinAppDriver or use forked WebDriverIO.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 27, 2019
@licanhua licanhua added Area: Tests and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) bug labels Aug 27, 2019
@licanhua licanhua self-assigned this Aug 27, 2019
@christian-bromann
Copy link

@licanhua I don't mind adding a workaround for WinAppDriver for WebdriverIO but this workaround should be an opt-in solution so that the default behavior remains the same.

@licanhua
Copy link
Contributor Author

Before WinAppDriver fix it, I worked around the problem in #2975 by

    "webdriverio": "^5.10.1",
    "webdriver": "git+https://github.com/react-native-windows/webdriver.git",

I keep this PR open until I adopted the new WinAppDriver.

@chrisglein chrisglein added this to the vNext Milestone 3 milestone Sep 6, 2019
@licanhua licanhua mentioned this issue Oct 1, 2019
Merged
@licanhua licanhua mentioned this issue Oct 10, 2019
Merged
@licanhua
Copy link
Contributor Author

Need to re-enable webdriverio bump which is disabled in #3386

@licanhua
Copy link
Contributor Author

WinAppDriver fixed it on v1.2-RC
appium-windows-driver fixed in 1.7.0 .

Because WinAppDriver requires admin permission to install it, and our build machine is still using WinAppDriver 1.1.
This task can be unblocked if any of below tasked can be resolved:

  1. WinAppDriver can be deployed without admin permission. Ship WinAppDriver binaries as zip package together with MSI files and allow WinAppDriver to be run in any folder WinAppDriver#913
  2. Microsoft hosted agent is using WinAppDriver 1.2-RC.
  3. Move CI Loop to machines with more hard drive space #3759, we host our own build machine and we can install WinAppDriver on it.

@NickGerleman
Copy link
Collaborator

I just added some selective dependency resolutions to our main package.json to ensure we use old versions of some dependencies if we regen our lockfile. We should make sure to remove this when we upgrade.

Confirmed the hosted agent is still on WinAppDriver 1.1

NickGerleman added a commit to NickGerleman/react-native-windows that referenced this issue Feb 22, 2020
@NickGerleman
Add more dependencies for WebDriverIO
c0e39d4 
We hardcode an old version of WebderiverIO beacuse of microsoft#3019. These seem to have loose dependency requirements, because the change to deuplicate packages broke this (see webdriverio/webdriverio#4104). Hardcode resolutions in E2ETest for existing versions of wdio packages in the meantime.
ghost pushed a commit that referenced this issue Feb 22, 2020
@NickGerleman
Initial commit of override tooling (#4158)
638c698 
* Initial commit of override tooling

Add a foundation for new override tooling described in #4104. This includes:

- Build scripts, lint scripts, config files, etc
- Logic for parsing and checking validity of an override manifest
- Unit tests for override manifest logic
- Abstractions to allow fetching React Native files of arbtrary versions

A lot of this is foundational. The override logic has been well-tested,
and the Git logic has been manually tested, but we don't have much
end-to-end set up yet.

* Address comments and deuplicate lockfile

* Add more dependencies for WebDriverIO

We hardcode an old version of WebderiverIO beacuse of #3019. These seem to have loose dependency requirements, because the change to deuplicate packages broke this (see webdriverio/webdriverio#4104). Hardcode resolutions in E2ETest for existing versions of wdio packages in the meantime.
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 10, 2020
@kmelmon kmelmon self-assigned this Aug 25, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 25, 2020
@NickGerleman NickGerleman mentioned this issue Sep 29, 2020
Closed
@NickGerleman
Copy link
Collaborator

We have new WinAppDriver now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmelmon kmelmon

Labels
Area: Test Infrastructure enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@christian-bromann @NickGerleman @licanhua @chrisglein @kmelmon