fix(windows): build break on Visual Studio 16.9

microsoft · Mar 15, 2021 · dda4759 · dda4759
1 parent 903e7fa
commit dda4759
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -368,7 +368,7 @@ jobs:
     steps:
       - name: Set up MSBuild
         uses: microsoft/[email protected]
-      - name: Setup VSTest.console.exe
+      - name: Set up VSTest.console.exe
         uses: darenm/Setup-VSTest@v1
       - name: Set up Node.js
         uses: actions/setup-node@v1

diff --git a/windows/ReactTestApp/Manifest.cpp b/windows/ReactTestApp/Manifest.cpp
@@ -118,7 +118,7 @@ namespace ReactTestApp
     {
         std::string json;
         {
-            std::ifstream stream(filename);
+            std::ifstream stream(filename, std::ios::binary | std::ios::in);
 
             stream.seekg(0, std::ios::end);
             json.reserve(static_cast<size_t>(stream.tellg()));