-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment out failing circle ci test #945
Conversation
|
007529e
to
1422de9
Compare
@HeyImChris @harrieshin The failing circle-ci tests now pass, and #946 should take care of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI is still failing? If we can keep most CI tests in tact and passing then that's great. We also don't really rely on CircleCI much anyway so could do away with them too
test_js and test_js_prev_lts both now pass. The failing "analyze_pr" is bc of danger bot which I fixed with #946 |
* comment out test * Update run-ci-e2e-tests.js * Update run-ci-e2e-tests.js
Please select one of the following
Summary
The
Flow Check
phase of our End to End Circle CI tests fails. This seems to be because the E2E test is installing _react-native-macosversion 0.63 instead of latest (which is missing the
Colors.darker` variable, which is how I figured that out. I haven't figured it out yet (perhaps #944 will help?), but this is blocking PRs quite a bit. Let's comment it out for nowChangelog
[Internal] [Removed] - Removed Flow check test from E2E tests temporarily
Test Plan