Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out failing circle ci test #945

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 9, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The Flow Check phase of our End to End Circle CI tests fails. This seems to be because the E2E test is installing _react-native-macosversion 0.63 instead of latest (which is missing theColors.darker` variable, which is how I figured that out. I haven't figured it out yet (perhaps #944 will help?), but this is blocking PRs quite a bit. Let's comment it out for now

Changelog

[Internal] [Removed] - Removed Flow check test from E2E tests temporarily

Test Plan

@pull-bot
Copy link

pull-bot commented Jan 9, 2022

Fails
🚫

❗ Base Branch - The base branch for this PR is something other than master. Are you sure you want to target something other than the master branch?

Generated by 🚫 dangerJS against 21cdb45

@Saadnajmi Saadnajmi marked this pull request as ready for review January 9, 2022 10:44
@Saadnajmi Saadnajmi requested a review from alloy as a code owner January 9, 2022 10:44
@Saadnajmi
Copy link
Collaborator Author

@HeyImChris @harrieshin The failing circle-ci tests now pass, and #946 should take care of the analyze_pr check

@Saadnajmi Saadnajmi changed the title [Draft] Comment out failing circle ci test Comment out failing circle ci test Jan 9, 2022
Copy link

@HeyImChris HeyImChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is still failing? If we can keep most CI tests in tact and passing then that's great. We also don't really rely on CircleCI much anyway so could do away with them too

@Saadnajmi
Copy link
Collaborator Author

Looks like the CI is still failing? If we can keep most CI tests in tact and passing then that's great. We also don't really rely on CircleCI much anyway so could do away with them too

test_js and test_js_prev_lts both now pass. The failing "analyze_pr" is bc of danger bot which I fixed with #946

@HeyImChris HeyImChris merged commit bd55cf3 into microsoft:main Jan 12, 2022
@Saadnajmi Saadnajmi deleted the comment-out-ci branch January 12, 2022 18:33
@Saadnajmi Saadnajmi mentioned this pull request Jan 14, 2022
4 tasks
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 19, 2022
* comment out test

* Update run-ci-e2e-tests.js

* Update run-ci-e2e-tests.js
@Saadnajmi Saadnajmi mentioned this pull request Jan 19, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants