Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Add event listeners to Scheduler #1481

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

christophpurrer
Copy link

@christophpurrer christophpurrer commented Nov 11, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry-pick a [email protected] commit into the current main branch:
facebook@e51e19e

Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties.

Changelog

Changelog: [Added] Add listeners to allow intercepting events in C++ core.

Test Plan

Build rn-tester with Fabric enabled
bundle install && USE_FABRIC=1 bundle exec pod install
and run it.
image

Flow

flow
Version mismatch! Server binary is Flow v0.170.0 but we are using v0.170.0
Restarting command using the same binary as the server
No errors!

@christophpurrer christophpurrer requested a review from a team as a code owner November 11, 2022 10:54
Summary:
Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties.

Changelog: [Added] Add listeners to allow intercepting events in C++ core.

Reviewed By: cipolleschi

Differential Revision: D35312534

fbshipit-source-id: ec924b57fd0c0dabf7be7b886dbef23bf3170d6c

# Conflicts:
#	packages/rn-tester/Podfile.lock
@Saadnajmi Saadnajmi merged commit 372044f into microsoft:main Nov 11, 2022
@christophpurrer christophpurrer deleted the eventListener branch November 11, 2022 22:33
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
Summary:
Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties.

Changelog: [Added] Add listeners to allow intercepting events in C++ core.

Reviewed By: cipolleschi

Differential Revision: D35312534

fbshipit-source-id: ec924b57fd0c0dabf7be7b886dbef23bf3170d6c

# Conflicts:
#	packages/rn-tester/Podfile.lock

Co-authored-by: Nicola Corti <[email protected]>
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
Summary:
Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties.

Changelog: [Added] Add listeners to allow intercepting events in C++ core.

Reviewed By: cipolleschi

Differential Revision: D35312534

fbshipit-source-id: ec924b57fd0c0dabf7be7b886dbef23bf3170d6c

# Conflicts:
#	packages/rn-tester/Podfile.lock

Co-authored-by: Nicola Corti <[email protected]>
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
Summary:
Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties.

Changelog: [Added] Add listeners to allow intercepting events in C++ core.

Reviewed By: cipolleschi

Differential Revision: D35312534

fbshipit-source-id: ec924b57fd0c0dabf7be7b886dbef23bf3170d6c

# Conflicts:
#	packages/rn-tester/Podfile.lock

Co-authored-by: Nicola Corti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants