Add cursor style to Text #1469
Merged
Add cursor style to Text #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We need this for URLs to show a pointer cursor as we render URLs as Text in Messenger Desktop.
Test Plan:
RNTester > Text:
{F612914000}
Reviewers: skyle
Reviewed By: skyle
Subscribers: eliwhite
Differential Revision: https://phabricator.intern.facebook.com/D28162138
Tasks: T78743077
Signature: 28162138:1620330813:8d90a29258ff560df30403fda9ce04df430caee9
Saadnajmi
approved these changes
Nov 10, 2022
|
Any blocker for this one? |
|
This is ready! Just had a lint fix. |
Can you mark it as not a draft so I can merge it? :) |
|
Oops, my bad! 😅 |
|
Great to see this merged! |
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* Add cursor style to Text
Summary: We need this for URLs to show a pointer cursor as we render URLs as Text in Messenger Desktop.
Test Plan:
RNTester > Text:
{F612914000}
Reviewers: skyle
Reviewed By: skyle
Subscribers: eliwhite
Differential Revision: https://phabricator.intern.facebook.com/D28162138
Tasks: T78743077
Signature: 28162138:1620330813:8d90a29258ff560df30403fda9ce04df430caee9
* Remove un-necessary setter
* Add back whitespace!
* yarn lint
Co-authored-by: Liron Yahdav <[email protected]>
Co-authored-by: Shawn Dempsey <[email protected]>
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 5, 2024
Summary: Implement the cursor style prop for iOS (and consequently, visionOS), as described in this RFC: react-native-community/discussions-and-proposals#750 See related PR in React Native macOS, where we target macOS and visionOS (not running in iPad compatibility mode) with the same change: microsoft#2080 Docs update: facebook/react-native-website#4033 ## Changelog: [IOS] [ADDED] - Implement cursor style prop Pull Request resolved: #43078 Test Plan: See the added example page, running on iOS with the new architecture enabled. This also runs the same on the old architecture. https://github.com/facebook/react-native/assets/6722175/2af60a0c-1c1f-45c4-8d66-a20f6d5815df See the example page running on all three apple platforms. The JS is slightly different because: 1. The "macOS Cursors" example is not part of this PR but the one in React Native macOS. 2. This PR (and exapmple) has went though a bunch of iterations and It got hard taking videos of every change 😅 https://github.com/facebook/react-native/assets/6722175/7775ba7c-8624-4873-a735-7665b94b7233 ## Notes - React Native macOS added the cursor prop to View with microsoft#760 and Text with microsoft#1469 . Much of the implementation comes from there. - Due to an Apple bug, as of iOS 17.4 Beta 4, the shape of the iOS cursor hover effect doesn't render in the correct bounds (but it does on visionOS). I've worked around it with an ifdef. The result is that the hover effect will work on iOS and visionOS, but not iPad apps running in compatibility mode on visionOS. Reviewed By: NickGerleman Differential Revision: D54512945 Pulled By: vincentriemer fbshipit-source-id: 699e3a01a901f55a466a2c1a19f667aede5aab80
huntie
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 11, 2024
Summary: Implement the cursor style prop for iOS (and consequently, visionOS), as described in this RFC: react-native-community/discussions-and-proposals#750 See related PR in React Native macOS, where we target macOS and visionOS (not running in iPad compatibility mode) with the same change: microsoft#2080 Docs update: facebook/react-native-website#4033 ## Changelog: [IOS] [ADDED] - Implement cursor style prop Pull Request resolved: #43078 Test Plan: See the added example page, running on iOS with the new architecture enabled. This also runs the same on the old architecture. https://github.com/facebook/react-native/assets/6722175/2af60a0c-1c1f-45c4-8d66-a20f6d5815df See the example page running on all three apple platforms. The JS is slightly different because: 1. The "macOS Cursors" example is not part of this PR but the one in React Native macOS. 2. This PR (and exapmple) has went though a bunch of iterations and It got hard taking videos of every change 😅 https://github.com/facebook/react-native/assets/6722175/7775ba7c-8624-4873-a735-7665b94b7233 ## Notes - React Native macOS added the cursor prop to View with microsoft#760 and Text with microsoft#1469 . Much of the implementation comes from there. - Due to an Apple bug, as of iOS 17.4 Beta 4, the shape of the iOS cursor hover effect doesn't render in the correct bounds (but it does on visionOS). I've worked around it with an ifdef. The result is that the hover effect will work on iOS and visionOS, but not iPad apps running in compatibility mode on visionOS. Reviewed By: NickGerleman Differential Revision: D54512945 Pulled By: vincentriemer fbshipit-source-id: 699e3a01a901f55a466a2c1a19f667aede5aab80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
#760 Added support for changing cursor styles for views.
#1346 changed RCTTextView to use NSTextView api's with support for customizing cursor.
Differential Revision: https://phabricator.intern.facebook.com/D28162138
Change-log
[macOS][Added] - Add cursor styles to Text View
Test Plan
CleanShot.2022-11-03.at.17.40.23.mp4