[CocoaPods] Resolve dependencies at parent level #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary versus using subspecs since CocoaPods needs to be able to resolve the dependencies properly at the parent workspace level based on needed versions. Otherwise, you end up with very opaque linking errors.
|
|
itoys
approved these changes
Apr 2, 2018
mistikk
added a commit
to ecency/react-native-code-push
that referenced
this pull request
May 27, 2019
)" This reverts commit 58be2bc.
mistikk
added a commit
to ecency/react-native-code-push
that referenced
this pull request
May 27, 2019
Revert "[CocoaPods] Resolve dependencies at parent level (microsoft#1210)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Subspecs should not be used as a means to add/remove 3rd party code that CodePush depends upon. It's meant only to add/remove features within a given library itself.
When other projects also rely upon those 3rd party libraries, subspecs break things because they don't allow you to do version resolving and dependency management like CocoaPods does by default.
Changes
Instead of using subspecs that reference some local files in the repo, we let CocoaPods resolve dependencies based upon versions. Otherwise, you end up with very opaque linking errors trying to add/remove subspecs.
I would recommend using the same approach of using dependency resolving for all other installation methods like Carthage and leave manual installation as an "at your own risk" like it's meant to be.
Update Instructions
Updaters will just need to:
$ bundle exec pod update CodePush