Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply flake8+pycodestyles autofixes #342

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Nov 8, 2024

(based on #339, so merge that one first) Done
Overlaps some import changes with #341, probably best to merge that one first as it has automated fixes.

I added W to Ruff's extend-select https://docs.astral.sh/ruff/rules/#pycodestyle-e-w + https://docs.astral.sh/ruff/rules/#pyflakes-f and manually fixed all lint issues.
F401 is ignored because it would change which symbols are even visible for Pylance. Which may negatively affect users, especially if the symbol wasn't meant to be re-exported.

@Avasam Avasam marked this pull request as draft November 8, 2024 04:09
@Avasam Avasam force-pushed the Apply-pycodestyles-autofixes branch 2 times, most recently from 057c01d to 972571a Compare November 10, 2024 19:31
@Avasam Avasam marked this pull request as ready for review November 10, 2024 19:31
@Avasam Avasam force-pushed the Apply-pycodestyles-autofixes branch from 972571a to 3263aa3 Compare November 22, 2024 18:01
@Avasam Avasam force-pushed the Apply-pycodestyles-autofixes branch from 3263aa3 to 39730c2 Compare January 28, 2025 20:45
@Avasam Avasam force-pushed the Apply-pycodestyles-autofixes branch from 39730c2 to 42cb5f0 Compare January 28, 2025 20:46
@Avasam Avasam marked this pull request as draft January 30, 2025 04:19
@Avasam Avasam marked this pull request as ready for review January 30, 2025 04:53
@debonte
Copy link
Contributor

debonte commented Jan 30, 2025

@Avasam, is there any particular order that the remaining PRs should be merged in?

@Avasam
Copy link
Contributor Author

Avasam commented Jan 30, 2025

@Avasam, is there any particular order that the remaining PRs should be merged in?

Not really. They can be done in any order. There's some overlap, but I'll deal with conflicts and new issues as they come up.
Also feel free to squash merge them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants