-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply flake8+pycodestyles autofixes #342
Open
Avasam
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
Avasam:Apply-pycodestyles-autofixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
057c01d
to
972571a
Compare
972571a
to
3263aa3
Compare
3263aa3
to
39730c2
Compare
39730c2
to
42cb5f0
Compare
…sam/python-type-stubs into Apply-pycodestyles-autofixes
…into Apply-pycodestyles-autofixes
@Avasam, is there any particular order that the remaining PRs should be merged in? |
Not really. They can be done in any order. There's some overlap, but I'll deal with conflicts and new issues as they come up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #339, so merge that one first)DoneOverlaps some import changes with #341, probably best to merge that one first as it has automated fixes.
I added
W
to Ruff'sextend-select
https://docs.astral.sh/ruff/rules/#pycodestyle-e-w + https://docs.astral.sh/ruff/rules/#pyflakes-f and manually fixed all lint issues.F401
is ignored because it would change which symbols are even visible for Pylance. Which may negatively affect users, especially if the symbol wasn't meant to be re-exported.