-
Notifications
You must be signed in to change notification settings - Fork 133
Conversation
This is great. Many thanks. I hope #1988 can be fixed soon. |
There seem to be some regressions in the |
Minimized differences and ported fixes from PRs that were not taken due to compatibility problems with old code. |
What happened to |
If you run the whole test suite, many of the |
Those are not cached, they turn this way when you re-run individual tests. What fails for you in highlight and imports? Are you on 3.8 or higher? |
Well, this is embarrassing. I'm still on your |
Yeah, now that I run the actual code it passes... 😄 I'll spot check this on some real code. |
This should be off my fork, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it with a few projects, things appear to work as they do now (just without the loop messages, of course).
Is these anything that can be done on Code comment level so this bug will not be introduced again? Are there regression tests possible? |
Undo #1686. Basically fork right before the PR then cherry pick changes on top. Also removes caching services.
Fixes #1988 and probably some others - to be verified.
Some tests became less stable due to old loop resolution issues.