Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Support goto definition in library files #1861

Merged
merged 34 commits into from
Mar 18, 2020

Conversation

MikhailArkhipov
Copy link

Fixes #840

    "python.analysis.memory.keepLibraryAst": true

MikhailArkhipov added 29 commits September 30, 2019 12:03
@MikhailArkhipov MikhailArkhipov added this to the December 2019.2 milestone Jan 2, 2020
@jakebailey
Copy link
Member

Can you remerge master to even out the diff with the cherry picked commits in the other PR?

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All test failures I see are known.

@jakebailey jakebailey merged commit 8d42298 into microsoft:master Mar 18, 2020
@MikhailArkhipov MikhailArkhipov deleted the libref2 branch March 19, 2020 17:49
MikhailArkhipov pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Don't suppress LHS diagnostics on augmented assign

* Revert "Don't suppress LHS diagnostics on augmented assign"

This reverts commit 6109ac7.

* Escape [ and ]

* PR feedback

* Fix navigation to local unknown parameters

* Enable option for library code navigation

* Eval both sides of binary of for references

* Simplify condition

Co-authored-by: Jake Bailey <[email protected]>
MikhailArkhipov pushed a commit that referenced this pull request Jun 15, 2020
* Remove stale reference

* Don't suppress LHS diagnostics on augmented assign

* Revert "Don't suppress LHS diagnostics on augmented assign"

This reverts commit 6109ac7.

* Escape [ and ]

* PR feedback

* Fix navigation to local unknown parameters

* Enable option for library code navigation

* Eval both sides of binary of for references

* Simplify condition

Co-authored-by: Jake Bailey <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support goto definition in library files
2 participants