This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Log parse exceptions instead of just throwing them away #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Nov 8, 2019
heejaechang
reviewed
Nov 8, 2019
heejaechang
approved these changes
Nov 8, 2019
bschnurr
approved these changes
Nov 8, 2019
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
(cherry picked from commit 1c9f8fe)
MikhailArkhipov
pushed a commit
that referenced
this pull request
Jun 15, 2020
(cherry picked from commit 1c9f8fe)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging for #1776.
Doesn't fix the core issue that we're spawning tasks we can't keep track of, but helps trying to find the crashes.