This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Fix module cycle handling #1584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Analysis/Ast/Impl/Analyzer/PythonAnalyzerSession.cs # src/Analysis/Ast/Impl/Dependencies/DependencyResolver.cs
|
Please don't merge the PR until 9/30, I'd like to run the tests on my main machine. |
|
Most probably conflicts with #1565 which changed how variables/members are exposed from variable modules. |
|
In the PR branch:
|
src/Analysis/Ast/Impl/Analyzer/Handlers/LoopImportedVariableHandler.cs
Outdated
Show resolved
Hide resolved
src/Analysis/Ast/Impl/Analyzer/Handlers/SimpleImportedVariableHandler.cs
Show resolved
Hide resolved
This was referenced Sep 28, 2019
Closed
# Conflicts: # src/Analysis/Ast/Impl/Analyzer/Handlers/FromImportHandler.cs # src/Analysis/Ast/Impl/Analyzer/Handlers/ImportHandler.cs
# Conflicts: # src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.cs # src/Analysis/Ast/Impl/Modules/PythonVariableModule.cs # src/Analysis/Ast/Impl/Modules/Resolution/ModuleResolutionBase.cs
|
Reopen from another branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the way we handle cycle dependencies of modules.
Previously, after finding the loop, we have determined some random path to walk over those modules and walked twice over it. With new approach, we first collect information about location of imports and variables in global scope of the modules in the loop, and then try to find a starting module. After that, we do the analysis starting from that module. Analyzes for modules are saved only after they are obtained for all modules in the loop.