Added a map of open documents to the languageServerBase class. It is … #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…responsible for applying any delta changes and updating the contents for each of the workspaces associated with that file. This allows source code contents to be shared between workspaces, which reduces memory usage. It also eliminates a correctness issue that can occur if new workspaces are added after files are open. It addresses #4994.
…ol matching when there are multiple levels of protocol inheritance and a method that uses `Self` in its signature. This addresses #4966.
rchiodo
approved these changes
Apr 27, 2023
bschnurr
reviewed
Apr 27, 2023
| @@ -1210,6 +1233,8 @@ export abstract class LanguageServerBase implements LanguageServerInterface { | |||
| workspaces.forEach((w) => { | |||
| w.service.setFileClosed(filePath); | |||
| }); | |||
|
|
|||
| this.openFileMap.delete(filePath); | |||
There was a problem hiding this comment.
should we clear 'openFileMap' in 'onShutdown' ?
There was a problem hiding this comment.
I don't think there's a need to do so, but it probably also doesn't hurt.
rchiodo
reviewed
Apr 27, 2023
| @@ -318,7 +317,7 @@ export class AnalyzerService { | |||
| updateOpenFileContents( | |||
| path: string, | |||
| version: number | null, | |||
| contents: TextDocumentContentChangeEvent[], | |||
There was a problem hiding this comment.
@heejaechang I believe this would mean we'd have to do updates for say fixall differently. Maybe other spots too.
There was a problem hiding this comment.
I think this works fine for the current fixall strategy. These changes are applied only to source files associated with a cloned program.
There was a problem hiding this comment.
Oh it looks like fixall uses something you already fixed. the workspaceEditUtils.applyDocumentChanges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…responsible for applying any delta changes and updating the contents for each of the workspaces associated with that file. This allows source code contents to be shared between workspaces, which reduces memory usage. It also eliminates a correctness issue that can occur if new workspaces are added after files are open. It addresses #4994.