Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative imports with 1.1.280 and reportMissingModuleSource = true are incorrectly reported #4212

Closed
Dr-Irv opened this issue Nov 20, 2022 · 2 comments
Labels
addressed in next version Issue is fixed and will appear in next published version bug Something isn't working

Comments

@Dr-Irv
Copy link

Dr-Irv commented Nov 20, 2022

Describe the bug
In the pandas-stubs repo, our type checking works fine with pyright 1.1.279. But with 1.1.280, the relative imports are coming up as " Import ".rolling" could not be resolved from source (reportMissingModuleSource)" . (for example) We have reportMissingModuleSource=true, but this wasn't an issue with version 1.1.279

To Reproduce
Install the pandas-stubs repo, and do pyright pandas-stubs with pyright version 1.1.280

erictraut pushed a commit that referenced this issue Nov 20, 2022
@erictraut
Copy link
Collaborator

Apologies for the regression. This will be addressed in the next release.

@erictraut erictraut added bug Something isn't working addressed in next version Issue is fixed and will appear in next published version labels Nov 20, 2022
@erictraut
Copy link
Collaborator

This is addressed in pyright 1.1.281, which I just published. It will also be included in a future release of pylance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed in next version Issue is fixed and will appear in next published version bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants