Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new separator for role parsing logic #797

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Conversation

melionel
Copy link
Contributor

@melionel melionel commented Oct 17, 2023

Description

add new separator for role parsing logic in chat string

  • for system/user/assistant/function role, support single # prefix;
  • for function's name/content role, support double # prefix

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@melionel melionel requested a review from a team as a code owner October 17, 2023 06:33
@github-actions github-actions bot added the promptflow-tools promptflow tools code label Oct 17, 2023
@melionel melionel merged commit 2ef0182 into main Oct 17, 2023
7 checks passed
@melionel melionel deleted the mengla/new_separator branch October 17, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants