Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing role in prompt issue #781

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

chjinche
Copy link
Contributor

@chjinche chjinche commented Oct 16, 2023

Description

Issue:
image

Root cause:
Caused by inappropriate regrex expr to match role in prompt. It is unexpected to match role word if it is in content string. For example, should not identify function as a role for input "system:\nthis is my function:\ndef hello"

Solution:
Fixed by modifying the regrex expr and added more tests of parsing logic.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@chjinche chjinche requested a review from a team as a code owner October 16, 2023 07:30
@github-actions github-actions bot added the promptflow-tools promptflow tools code label Oct 16, 2023
@chjinche chjinche force-pushed the chjinche/fix_role_parsing branch 3 times, most recently from a175411 to 2e4aa3f Compare October 16, 2023 07:42
DaweiCai
DaweiCai previously approved these changes Oct 16, 2023
@chjinche chjinche merged commit 92ed746 into main Oct 16, 2023
7 checks passed
@chjinche chjinche deleted the chjinche/fix_role_parsing branch October 16, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants