Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom strong type connection in script tool (Simplified) #733

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Support custom strong type connection in script tool (Simplified) #733

merged 4 commits into from
Oct 16, 2023

Conversation

16oeahr
Copy link
Contributor

@16oeahr 16oeahr commented Oct 12, 2023 •
edited
Loading

Description

doc: (Simplify) Support custom strong type connection in script tool.docx

Support custom strong type connection in script tool.

  1. User can define and use their own custom strong type conenction in their script tool:
    image
  2. The connection type would be shown as custom connection in flow
    image
  3. The connection value is the a normal custom connection.
  4. The way of creating this custom connection is no different from the usual of a CustomConnection. User needs to fill in the key value of their custom defined connection.
    image

local to cloud test command:
preparation:
install promptflow package with supported feature in test runtime.

pfazure run create --subscription 96aede12-2f73-41cb-b983-6d11a904839b -g promptflow -w chjinche-pf-eus --flow D:\testscripts\test_pf_cmd\tests\new-empty-flow-created-at-2023-10-10 --data D:\testscripts\test_pf_cmd\tests\new-empty-flow-created-at-2023-10-10\data.jsonl --runtime test-compute

Run success link: https://ml.azure.com/prompts/flow/4d49a4bb-8594-4ccd-842e-73a9aeb3fcb1/27ebca2e-8a12-40a9-9f01-bd1ca72815c2/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourcegroups/promptflow/providers/Microsoft.MachineLearningServices/workspaces/chjinche-pf-eus&tid=72f988bf-86f1-41af-91ab-2d7cd011db47

@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 02:32 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 02:32 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 02:32 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 02:32 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 02:32 — with GitHub Actions Inactive
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Oct 12, 2023
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

SDK CLI Global Config Test Result user/yalu4/support_cstc_script

2 tests   2 ✔️  44s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fadbff3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Executor Unit Test Result user/yalu4/support_cstc_script

    2 files      2 suites   1m 45s ⏱️
365 tests 365 ✔️ 0 💤 0 ❌
708 runs  707 ✔️ 1 💤 0 ❌

Results for commit fadbff3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Executor E2E Test Result user/yalu4/support_cstc_script

    2 files      2 suites   19m 33s ⏱️
102 tests 100 ✔️ 2 💤 0 ❌
204 runs  198 ✔️ 6 💤 0 ❌

Results for commit fadbff3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

SDK PFS E2E Test Result user/yalu4/support_cstc_script

8 tests   8 ✔️  23s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fadbff3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

SDK CLI Test Result user/yalu4/support_cstc_script

    2 files      2 suites   29m 9s ⏱️
292 tests 278 ✔️ 14 💤 0 ❌
584 runs  556 ✔️ 28 💤 0 ❌

Results for commit fadbff3.

♻️ This comment has been updated with latest results.

@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from 29aa602 to 30eb6e1 Compare October 12, 2023 04:01
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 04:01 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 04:01 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 04:01 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 04:01 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 04:01 — with GitHub Actions Inactive
@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from 30eb6e1 to df0f8e6 Compare October 12, 2023 05:40
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 05:40 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 05:40 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 05:40 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 05:40 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 05:40 — with GitHub Actions Inactive
@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from df0f8e6 to 0b645c2 Compare October 12, 2023 07:30
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 07:30 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 07:30 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 07:30 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 07:30 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 12, 2023 07:30 — with GitHub Actions Inactive
@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from cd17adf to 709e924 Compare October 13, 2023 07:53
@16oeahr 16oeahr temporarily deployed to internal October 13, 2023 07:53 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 13, 2023 07:53 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 13, 2023 07:53 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 13, 2023 07:53 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 13, 2023 07:53 — with GitHub Actions Inactive
@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from 709e924 to 035078d Compare October 16, 2023 00:41
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 00:41 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 00:41 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 00:41 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 00:41 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 00:41 — with GitHub Actions Inactive
@16oeahr 16oeahr force-pushed the user/yalu4/support_cstc_script branch from 035078d to fadbff3 Compare October 16, 2023 01:13
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 01:13 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 01:13 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 01:13 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 01:13 — with GitHub Actions Inactive
@16oeahr 16oeahr temporarily deployed to internal October 16, 2023 01:13 — with GitHub Actions Inactive
@16oeahr 16oeahr merged commit 2aa2ef8 into main Oct 16, 2023
31 checks passed
@16oeahr 16oeahr deleted the user/yalu4/support_cstc_script branch October 16, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumoslnt lumoslnt lumoslnt approved these changes

@chjinche chjinche chjinche approved these changes

@brynn-code brynn-code brynn-code approved these changes

Assignees
No one assigned
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@16oeahr @brynn-code @chjinche @lumoslnt