Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numexpr is one optional package for langchain, install it for e2e test. #682

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Oct 7, 2023

Description

Langchain changed numexpr as optional package in langchain-ai/langchain#11049.
So, pip install langchain will not install numexpr.
Add pip install numexpr to fix e2e test because we need call langchain.agents.load_tools.load_tools.

Test failed because can't apply this branch's yaml to install numexpr.
Trigger e2e test separately and test succeeded.
https://github.com/microsoft/promptflow/actions/runs/6440435201

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested a review from a team as a code owner October 7, 2023 08:52
@huaiyan huaiyan temporarily deployed to internal October 7, 2023 08:52 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Executor E2E Test Result robbenwang/install_numexpr_for_e2e

    2 files      2 suites   7m 50s ⏱️
102 tests   99 ✔️ 2 💤 1
204 runs  196 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit f8fd5cb.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan temporarily deployed to internal October 7, 2023 09:15 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Executor E2E Test Result

    2 files  ±0      2 suites  ±0   8m 27s ⏱️ -58s
102 tests ±0  100 ✔️ +1  2 💤 ±0  0  - 1 
204 runs  ±0  198 ✔️ +2  6 💤 ±0  0  - 2 

Results for commit f8fd5cb. ± Comparison against base commit e067bbe.

♻️ This comment has been updated with latest results.

zzn2
zzn2 previously approved these changes Oct 7, 2023
@huaiyan huaiyan force-pushed the robbenwang/install_numexpr_for_e2e branch from 6b8453e to f8fd5cb Compare October 7, 2023 09:49
@huaiyan huaiyan temporarily deployed to internal October 7, 2023 09:49 — with GitHub Actions Inactive
@huaiyan huaiyan temporarily deployed to internal October 7, 2023 09:49 — with GitHub Actions Inactive
@huaiyan huaiyan merged commit 0b96369 into main Oct 7, 2023
@huaiyan huaiyan deleted the robbenwang/install_numexpr_for_e2e branch October 7, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants