Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IndirectAttack evaluation enum to "xpia" #3729

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

diondrapeck
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@diondrapeck diondrapeck requested a review from a team as a code owner September 11, 2024 20:32
nagkumar91
nagkumar91 previously approved these changes Sep 11, 2024
@diondrapeck diondrapeck dismissed nagkumar91’s stale review September 11, 2024 20:42

The merge-base changed after approval.

Copy link

promptflow-evals test result

 12 files   12 suites   1h 46m 30s ⏱️
 64 tests  61 ✅  3 💤 0 ❌
768 runs  732 ✅ 36 💤 0 ❌

Results for commit 8943af7.

@diondrapeck diondrapeck merged commit 424dd18 into main Sep 11, 2024
74 of 76 checks passed
@diondrapeck diondrapeck deleted the add-xpia-aggregation branch September 11, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants