-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XPIA simulator and evaluator #3703
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oft/promptflow into feature/xpia-sim-and-eval
MilesHolland
previously approved these changes
Sep 4, 2024
MilesHolland
previously approved these changes
Sep 4, 2024
singankit
reviewed
Sep 4, 2024
singankit
reviewed
Sep 4, 2024
src/promptflow-evals/promptflow/evals/synthetic/adversarial_simulator.py
Show resolved
Hide resolved
singankit
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments please take a look
luigiw
previously approved these changes
Sep 4, 2024
diondrapeck
dismissed stale reviews from luigiw, singankit, and MilesHolland
via
September 4, 2024 18:20
7c7f7f5
MilesHolland
added a commit
that referenced
this pull request
Sep 6, 2024
A fork of the original XPIA sim/eval branch with additional fixes for bugs discovered last night. - changes the jailbreak check for combining templates to only account for upia (since xpia doesn't merge templates) - removes conversations as an input for xpia evals until the default override bug is fixed. - Accounts for new xpia evaluator return fields. - Changes the output base name of 'reasoning' fields for label-based evaluators to just 'reason' Original PR: #3703 --------- Co-authored-by: Diondra Peck <[email protected]> Co-authored-by: Diondra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines