Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XPIA simulator and evaluator #3703

Closed
wants to merge 52 commits into from
Closed

Conversation

diondrapeck
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

MilesHolland
MilesHolland previously approved these changes Sep 4, 2024
MilesHolland
MilesHolland previously approved these changes Sep 4, 2024
singankit
singankit previously approved these changes Sep 4, 2024
Copy link
Member

@singankit singankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments please take a look

luigiw
luigiw previously approved these changes Sep 4, 2024
@diondrapeck diondrapeck dismissed stale reviews from luigiw, singankit, and MilesHolland via 7c7f7f5 September 4, 2024 18:20
MilesHolland added a commit that referenced this pull request Sep 6, 2024
A fork of the original XPIA sim/eval branch with additional fixes for
bugs discovered last night.

- changes the jailbreak check for combining templates to only account
for upia (since xpia doesn't merge templates)
- removes conversations as an input for xpia evals until the default
override bug is fixed.
- Accounts for new xpia evaluator return fields.
- Changes the output base name of 'reasoning' fields for label-based
evaluators to just 'reason'

Original PR: #3703

---------

Co-authored-by: Diondra Peck <[email protected]>
Co-authored-by: Diondra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants