Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPT based evaluators to force output to be a single integer #3550

Merged
merged 12 commits into from
Jul 20, 2024

Conversation

luigiw
Copy link
Member

@luigiw luigiw commented Jul 15, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@luigiw luigiw requested a review from a team as a code owner July 15, 2024 23:34
Copy link

github-actions bot commented Jul 15, 2024

promptflow-evals test result

 12 files  ±  0   12 suites  ±0   1h 44m 54s ⏱️ + 34m 15s
 20 tests  -  19   20 ✅  -  18  0 💤  -  1  0 ❌ ±0 
240 runs   - 228  240 ✅  - 216  0 💤  - 12  0 ❌ ±0 

Results for commit 3887aa4. ± Comparison against base commit de5aa0f.

This pull request removes 39 and adds 20 tests. Note that renamed tests count towards both.
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[False-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[True-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_coherence
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_fluency
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_groundedness
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_prompt_based_with_dict_input
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_relevance
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_similarity
…
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_conversation_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_qa_sim_responds_with_one_response
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_rewrite_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_sim_init_with_prod_url
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_jailbreak_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_incorrect_scenario_raises_error
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[False-False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[True-False]
…

♻️ This comment has been updated with latest results.

nagkumar91
nagkumar91 previously approved these changes Jul 18, 2024
Copy link
Member

@w-javed w-javed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigiw
Copy link
Member Author

luigiw commented Jul 20, 2024

Fixes #3522 #3381

@luigiw luigiw merged commit f1e350d into main Jul 20, 2024
76 checks passed
@luigiw luigiw deleted the hancwang/fix-nan branch July 20, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants