Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split installation tests from other e2e tests. #3546

Merged
merged 17 commits into from
Jul 16, 2024

Conversation

nick863
Copy link
Contributor

@nick863 nick863 commented Jul 13, 2024

Description

In this PR we split the installation time tests from unit and e2e tests.

  • Unit tests and e2e tests are running now in editable install
  • Removed the building wheel step from the tests
  • Added new gate, which builds the wheel and then installs it into virtual environment and logging time.
  • Added test for logging, which, however, does not switched on in CI/CD.
  • Re-enable tests on python 3.9 in CI/CD as we do not depend on wheel in tests anymore i.e. we have separate test for creation of a functional wheel.

Example query to application insights:

let date_of_run=datetime("2024-07-02");
customEvents
| where timestamp > date_of_run
| where customDimensions has 'installation-test'
| extend parsed = parse_json(customDimensions)
| project 
      name,
      run_date=format_datetime(timestamp, 'yyyy-MM-dd'),
      metric = parsed['activity_name'],
      OS = strcat(parsed["OS"], "_", parsed["OS_release"]),
      python_version = tostring(parsed['python_version']),
      install_time_s=todecimal(parsed["install_time_s"])
| summarize performance = avg(install_time_s) by OS, name
| render columnchart with(
    kind=unstacked
)

Result:
image

See work item 3342618 for the inotial task and task 3339407 to enable tests on python 3.9. In this PR we are installing wheel with virtual env, which does not have issue mentioned in the bug.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner July 13, 2024 05:21
Copy link

github-actions bot commented Jul 15, 2024

promptflow-evals test result

 12 files   12 suites   1h 37m 31s ⏱️
 19 tests  18 ✅  1 💤 0 ❌
228 runs  216 ✅ 12 💤 0 ❌

Results for commit e62e9a3.

♻️ This comment has been updated with latest results.

@nick863 nick863 changed the title [Draft] Add separate installation test Split installation tests from other e2e tests. Jul 15, 2024
singankit
singankit previously approved these changes Jul 15, 2024
@nick863 nick863 requested review from ninghu and singankit July 15, 2024 23:17
@nick863 nick863 merged commit 93c211d into main Jul 16, 2024
74 checks passed
@nick863 nick863 deleted the nirovins/split_installation_time_test branch July 16, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants