-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split installation tests from other e2e tests. #3546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irovins/split_installation_time_test
promptflow-evals test result 12 files 12 suites 1h 37m 31s ⏱️ Results for commit e62e9a3. ♻️ This comment has been updated with latest results. |
nick863
changed the title
[Draft] Add separate installation test
Split installation tests from other e2e tests.
Jul 15, 2024
ninghu
reviewed
Jul 15, 2024
ninghu
reviewed
Jul 15, 2024
singankit
previously approved these changes
Jul 15, 2024
…irovins/split_installation_time_test
ninghu
approved these changes
Jul 15, 2024
wangchao1230
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we split the installation time tests from unit and e2e tests.
Example query to application insights:
Result:
See work item 3342618 for the inotial task and task 3339407 to enable tests on python 3.9. In this PR we are installing wheel with virtual env, which does not have issue mentioned in the bug.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines