Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add category to template_parameters in the output of simulations #3544

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

nagkumar91
Copy link
Member

@nagkumar91 nagkumar91 commented Jul 11, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nagkumar91 nagkumar91 requested a review from a team as a code owner July 11, 2024 19:31
Copy link

github-actions bot commented Jul 11, 2024

promptflow-evals test result

  9 files   -   3    9 suites   - 3   1h 12m 50s ⏱️ - 25m 24s
 19 tests  -  16   18 ✅  -  15  1 💤  -  1  0 ❌ ±0 
171 runs   - 249  162 ✅  - 234  9 💤  - 15  0 ❌ ±0 

Results for commit ee9977e. ± Comparison against base commit 52398d3.

This pull request removes 35 and adds 19 tests. Note that renamed tests count towards both.
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[False-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[True-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_content_safety_service_unavailable
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_individual_evaluator_prompt_based
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_individual_evaluator_prompt_based_with_dict_input
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_aggregation[False-False]
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_aggregation[False-True]
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_aggregation[True-False]
…
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_conversation_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_qa_sim_responds_with_one_response
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_rewrite_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_sim_init_with_prod_url
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_jailbreak_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_incorrect_scenario_raises_error
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[False-False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[True-False]
…
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_content_safety_service_unavailable
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_prompty_with_threadpool_implementation
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_with_content_safety_evaluator

♻️ This comment has been updated with latest results.

ninghu
ninghu previously approved these changes Jul 12, 2024
@nagkumar91 nagkumar91 merged commit 4f7f41f into main Jul 15, 2024
60 checks passed
@nagkumar91 nagkumar91 deleted the task/add_category_to_adv_sim_output branch July 15, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants