Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch timeout override #3501

Merged
merged 21 commits into from
Jul 22, 2024
Merged

Add batch timeout override #3501

merged 21 commits into from
Jul 22, 2024

Conversation

diondrapeck
Copy link
Contributor

@diondrapeck diondrapeck commented Jul 3, 2024

Description

Add environment variable option to set batch timeout limit.

Evaluation is only local currently, so no need to check user input.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@diondrapeck diondrapeck requested a review from a team as a code owner July 3, 2024 20:05
Copy link

github-actions bot commented Jul 3, 2024

promptflow-evals test result

 12 files  ±  0   12 suites  ±0   2h 23m 14s ⏱️ + 1h 11m 15s
 20 tests  -  20   20 ✅  -  19  0 💤  -  1  0 ❌ ±0 
240 runs   - 240  240 ✅  - 228  0 💤  - 12  0 ❌ ±0 

Results for commit ba0ee3a. ± Comparison against base commit 274121e.

This pull request removes 40 and adds 20 tests. Note that renamed tests count towards both.
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[False-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[True-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_qa_evaluator_for_nans
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_coherence
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_fluency
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_groundedness
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_prompt_based_with_dict_input
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_relevance
…
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_conversation_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_qa_sim_responds_with_one_response
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_rewrite_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_sim_init_with_prod_url
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_jailbreak_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_incorrect_scenario_raises_error
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[False-False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_content_safety_chat[True-False]
…

♻️ This comment has been updated with latest results.

singankit
singankit previously approved these changes Jul 19, 2024
@diondrapeck diondrapeck merged commit 6a57db2 into main Jul 22, 2024
76 checks passed
@diondrapeck diondrapeck deleted the batch-timeout branch July 22, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants