-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch timeout override #3501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow-evals test result 12 files ± 0 12 suites ±0 2h 23m 14s ⏱️ + 1h 11m 15s Results for commit ba0ee3a. ± Comparison against base commit 274121e. This pull request removes 40 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
ninghu
reviewed
Jul 11, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/proxy_client.py
Outdated
Show resolved
Hide resolved
ninghu
reviewed
Jul 11, 2024
singankit
reviewed
Jul 11, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/proxy_client.py
Outdated
Show resolved
Hide resolved
ninghu
reviewed
Jul 13, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/batch_run_context.py
Outdated
Show resolved
Hide resolved
ninghu
reviewed
Jul 13, 2024
… into batch-timeout
singankit
reviewed
Jul 15, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/batch_run_context.py
Outdated
Show resolved
Hide resolved
singankit
reviewed
Jul 15, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/batch_run_context.py
Show resolved
Hide resolved
singankit
reviewed
Jul 19, 2024
singankit
previously approved these changes
Jul 19, 2024
ninghu
reviewed
Jul 21, 2024
src/promptflow-evals/promptflow/evals/evaluate/_batch_run_client/batch_run_context.py
Outdated
Show resolved
Hide resolved
ninghu
approved these changes
Jul 22, 2024
singankit
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add environment variable option to set batch timeout limit.
Evaluation is only local currently, so no need to check user input.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines