Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring parity between eval and sim for azure_ai_project #3378

Merged
merged 13 commits into from
Jun 27, 2024

Conversation

nagkumar91
Copy link
Member

@nagkumar91 nagkumar91 commented Jun 5, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nagkumar91 nagkumar91 requested a review from a team as a code owner June 5, 2024 17:06
Copy link

github-actions bot commented Jun 5, 2024

promptflow-evals test result

  9 files  ±0    9 suites  ±0   2h 37m 21s ⏱️ + 8m 39s
 54 tests +1   47 ✅ +1   7 💤 ±0  0 ❌ ±0 
486 runs  +9  423 ✅ +9  63 💤 ±0  0 ❌ ±0 

Results for commit 861581a. ± Comparison against base commit 9a8c10d.

♻️ This comment has been updated with latest results.

Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Jun 19, 2024
@nagkumar91 nagkumar91 removed the no-recent-activity There has been no recent activity on this issue/pull request label Jun 24, 2024
singankit
singankit previously approved these changes Jun 24, 2024
luigiw
luigiw previously approved these changes Jun 25, 2024
@nagkumar91 nagkumar91 dismissed stale reviews from luigiw and singankit via 8d6247f June 25, 2024 16:34
@nagkumar91 nagkumar91 requested review from singankit and luigiw June 25, 2024 21:08
@nagkumar91 nagkumar91 merged commit ea1dd04 into main Jun 27, 2024
37 checks passed
@nagkumar91 nagkumar91 deleted the task/changeAdvSimInit branch June 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants