Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Executor] Enrich error message for flex flow #3054

Merged
merged 11 commits into from
Apr 29, 2024
Merged

[Executor] Enrich error message for flex flow #3054

merged 11 commits into from
Apr 29, 2024

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented Apr 28, 2024 •
edited
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

Currently for exceptions failed in flex flow's user code. The stack trace will lost and entry name is incorrect.
This PR added trace back to exception and refined entry name in error message.

Before:
image

After:
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@D-W- D-W- requested review from a team as code owners April 28, 2024 07:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result wanhan/fix_steam_sample

  4 files    4 suites   4m 7s ⏱️
238 tests 203 ✅  35 💤 0 ❌
952 runs  812 ✅ 140 💤 0 ❌

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

SDK CLI Global Config Test Result wanhan/fix_steam_sample

6 tests   6 ✅  1m 18s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

Executor Unit Test Result wanhan/fix_steam_sample

792 tests   792 ✅  3m 41s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

Executor E2E Test Result wanhan/fix_steam_sample

242 tests   237 ✅  5m 10s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2024 •
edited
Loading

SDK CLI Test Result wanhan/fix_steam_sample

    4 files      4 suites   57m 50s ⏱️
  664 tests   650 ✅ 13 💤 1 ❌
2 656 runs  2 603 ✅ 52 💤 1 ❌

For more details on these failures, see this check.

Results for commit d93e7a9.

♻️ This comment has been updated with latest results.

@D-W- D-W- merged commit ea1c37b into main Apr 29, 2024
53 of 54 checks passed
@D-W- D-W- deleted the wanhan/fix_steam_sample branch April 29, 2024 03:56
crazygao pushed a commit that referenced this pull request May 6, 2024
@D-W- @crazygao
[Executor] Enrich error message for flex flow (#3054)
87d9eaa 
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

Currently for exceptions failed in flex flow's user code. The stack
trace will lost and entry name is incorrect.
This PR added trace back to exception and refined entry name in error
message.

Before:

![image](https://github.com/microsoft/promptflow/assets/7776147/ad6e71b8-d691-4bc3-806f-7c7c748ad79f)

After:

![image](https://github.com/microsoft/promptflow/assets/7776147/e77011aa-0e3c-4d70-8f2d-948abf5e5549)



# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazygao crazygao crazygao left review comments

@thy09 thy09 thy09 approved these changes

@0mza987 0mza987 0mza987 approved these changes

Assignees
No one assigned
Labels
examples Improvements on examples promptflow promptflow-core promptflow-devkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D-W- @crazygao @0mza987 @thy09