-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change pf-tools to only depend on pf-core #2841
Conversation
…om/microsoft/promptflow into chesi/remove-existing-pf-depending
# Avoid circular dependencies: Use import 'from promptflow._internal' instead of 'from promptflow' | ||
# since the code here is in promptflow namespace as well | ||
from promptflow._internal import enable_cache, ToolProvider, tool, register_apis | ||
from promptflow._core.cache_manager import enable_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid using import path startswith _
, replace them with public methods.
try: | ||
# Do not support dynamic list if azure packages are not installed. | ||
from azure.mgmt.cognitiveservices import CognitiveServicesManagementClient | ||
from promptflow.azure.operations._arm_connection_operations import \ | ||
ArmConnectionOperations, OpenURLFailedUserError | ||
from promptflow.core._errors import OpenURLFailedUserError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please confirm if there are public import ways
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the |
Description
This PR contains:
Test image: promptflow.azurecr.io/promptflow-runtime:pr-1344775-v4
Exp link: https://ml.azure.com/prompts/flow/cfa1c054-13cb-4cfc-b3a6-359bf0493da9/d44ab050-7de4-4e8e-9adc-196cfceb706d/details?wsid=/subscriptions/96aede12-2f73-41cb-b983-6d11a904839b/resourceGroups/chesi-eastus/providers/Microsoft.MachineLearningServices/workspaces/chesi-promptflow&flight=pfnewllm,pfflowleveltool&tid=72f988bf-86f1-41af-91ab-2d7cd011db47
include tools:
get instance tests: old llm-vision uses dynamic list and uses "get_instance.get" to get connection obj, then selects the correct deployment name.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines