Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Executor] Use log_progress function to update last_log_count #2514

Merged
merged 7 commits into from
Mar 29, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Mar 27, 2024

Description

Bug impact

The progress logs for batch runs have been reduced.

Bug root cause

The value of last_log_count is wrong. It is the last completed count instead of the real last log count. This causes each loop to determine whether the count completed this time minus the count completed last time is greater than the log interval. At the same time, this difference is relatively small, and often does not reach the set interval, resulting in less logs.

Bug fix:

Use log_progress to update the last log count.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@PeiwenGaoMS PeiwenGaoMS requested review from a team as code owners March 27, 2024 12:37
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

SDK CLI Global Config Test Result devs/peiwen/fix_log_progress

3 tests   3 ✅  42s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 658594b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

promptflow SDK CLI Azure E2E Test Result devs/peiwen/fix_log_progress

  4 files    4 suites   4m 3s ⏱️
197 tests 177 ✅ 20 💤 0 ❌
788 runs  708 ✅ 80 💤 0 ❌

Results for commit 658594b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

Executor Unit Test Result devs/peiwen/fix_log_progress

729 tests   729 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 658594b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

Executor E2E Test Result devs/peiwen/fix_log_progress

218 tests   216 ✅  5m 33s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 658594b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 27, 2024

SDK CLI Test Result devs/peiwen/fix_log_progress

   12 files     12 suites   48m 37s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit 658594b.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS merged commit 5e9a7aa into main Mar 29, 2024
43 of 44 checks passed
@PeiwenGaoMS PeiwenGaoMS deleted the devs/peiwen/fix_log_progress branch March 29, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants