-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Executor] Use log_progress function to update last_log_count #2514
Conversation
SDK CLI Global Config Test Result devs/peiwen/fix_log_progress3 tests 3 ✅ 42s ⏱️ Results for commit 658594b. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result devs/peiwen/fix_log_progress 4 files 4 suites 4m 3s ⏱️ Results for commit 658594b. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result devs/peiwen/fix_log_progress729 tests 729 ✅ 3m 44s ⏱️ Results for commit 658594b. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result devs/peiwen/fix_log_progress218 tests 216 ✅ 5m 33s ⏱️ Results for commit 658594b. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result devs/peiwen/fix_log_progress 12 files 12 suites 48m 37s ⏱️ Results for commit 658594b. ♻️ This comment has been updated with latest results. |
…evs/peiwen/fix_log_progress
Description
Bug impact
The progress logs for batch runs have been reduced.
Bug root cause
The value of
last_log_count
is wrong. It is the last completed count instead of the real last log count. This causes each loop to determine whether the count completed this time minus the count completed last time is greater than the log interval. At the same time, this difference is relatively small, and often does not reach the set interval, resulting in less logs.Bug fix:
Use
log_progress
to update the last log count.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines