Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Separation] Separation of devkit and azure #2502

Merged
merged 24 commits into from
Mar 28, 2024
Merged

[Separation] Separation of devkit and azure #2502

merged 24 commits into from
Mar 28, 2024

Conversation

crazygao
Copy link
Contributor

@crazygao crazygao commented Mar 27, 2024 •
edited
Loading

Description

Move devkits and azures

image
image
image

We have some critical issues when install streamlit with poetry. And pf scripts, will fix in later patches.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@crazygao crazygao requested review from a team as code owners March 27, 2024 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

SDK CLI Test Result yigao/new_devkit

   12 files     12 suites   47m 47s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit c20e2ea.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result yigao/new_devkit

  4 files    4 suites   4m 2s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit c20e2ea.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

SDK CLI Global Config Test Result yigao/new_devkit

3 tests   2 ✅  44s ⏱️
1 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit c20e2ea.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Executor E2E Test Result yigao/new_devkit

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c20e2ea.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Executor Unit Test Result yigao/new_devkit

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c20e2ea.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the sdk prompt flow SDK label Mar 27, 2024
brynn-code
brynn-code previously approved these changes Mar 28, 2024
View reviewed changes
wangchao1230
wangchao1230 previously approved these changes Mar 28, 2024
View reviewed changes
@crazygao crazygao dismissed stale reviews from wangchao1230 and brynn-code via c20e2ea March 28, 2024 03:11
@crazygao crazygao merged commit 74117bb into main Mar 28, 2024
35 of 42 checks passed
@crazygao crazygao deleted the yigao/new_devkit branch March 28, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchao1230 wangchao1230 wangchao1230 approved these changes

@brynn-code brynn-code brynn-code approved these changes

@thy09 thy09 thy09 approved these changes

Assignees
No one assigned
Labels
cli prompt flow CLI fundamental promptflow sdk prompt flow SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazygao @thy09 @brynn-code @wangchao1230