-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix incorrect completed count of aggregation node for resume run #2492
Conversation
SDK CLI Global Config Test Result shimin/fix_resume_aggr3 tests 3 ✅ 42s ⏱️ Results for commit 95bcad8. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result shimin/fix_resume_aggr 4 files 4 suites 4m 34s ⏱️ Results for commit 95bcad8. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result shimin/fix_resume_aggr729 tests 729 ✅ 3m 45s ⏱️ Results for commit 95bcad8. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result shimin/fix_resume_aggr218 tests 216 ✅ 5m 17s ⏱️ Results for commit 95bcad8. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result shimin/fix_resume_aggr 12 files 12 suites 48m 51s ⏱️ Results for commit 95bcad8. ♻️ This comment has been updated with latest results. |
e37d15c
to
5c6d708
Compare
60c351b
to
4a1ae97
Compare
4a1ae97
to
95bcad8
Compare
Description
Currently we have the bug of returning wrong completed count of aggregation node for resume run. The completed count of aggregation node is 2, but the expected result is 1. That's because the previous aggregation result is also copied to current line_results and counted in the node_run_info.
To exclude the previous result of the aggregation node, we check all the nodes in previous_node_run_infos. If any aggregation node is loaded, we exclude it in _copy_previous_run_result.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines