Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix incorrect completed count of aggregation node for resume run #2492

Closed
wants to merge 6 commits into from

Conversation

Jasmin3q
Copy link
Contributor

Description

Currently we have the bug of returning wrong completed count of aggregation node for resume run. The completed count of aggregation node is 2, but the expected result is 1. That's because the previous aggregation result is also copied to current line_results and counted in the node_run_info.

To exclude the previous result of the aggregation node, we check all the nodes in previous_node_run_infos. If any aggregation node is loaded, we exclude it in _copy_previous_run_result.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Jasmin3q Jasmin3q requested a review from a team as a code owner March 26, 2024 12:37
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 26, 2024
Copy link

github-actions bot commented Mar 26, 2024

SDK CLI Global Config Test Result shimin/fix_resume_aggr

3 tests   3 ✅  42s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 95bcad8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

promptflow SDK CLI Azure E2E Test Result shimin/fix_resume_aggr

  4 files    4 suites   4m 34s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit 95bcad8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

Executor Unit Test Result shimin/fix_resume_aggr

729 tests   729 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 95bcad8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

Executor E2E Test Result shimin/fix_resume_aggr

218 tests   216 ✅  5m 17s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 95bcad8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 26, 2024

SDK CLI Test Result shimin/fix_resume_aggr

   12 files     12 suites   48m 51s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit 95bcad8.

♻️ This comment has been updated with latest results.

@Jasmin3q Jasmin3q closed this Mar 29, 2024
@Jasmin3q Jasmin3q deleted the shimin/fix_resume_aggr branch April 23, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants