Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup exporter logic as creating executor #2480

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add setup exporter logic as creating executor #2480

merged 1 commit into from
Mar 28, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Mar 26, 2024 •
edited
Loading

Description

Setting up exporter as creating executor.
Then we could skip setting up it in many places.
Will use e2e test to cover this scenario.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested a review from a team as a code owner March 26, 2024 06:43
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 26, 2024
@huaiyan huaiyan changed the title Add start exporter logic for multi-container. WIP: Add start exporter logic for multi-container. Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

SDK CLI Global Config Test Result devs/robbenwang_multi_container_exporter

3 tests   3 ✅  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ccdf0cf.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

promptflow SDK CLI Azure E2E Test Result devs/robbenwang_multi_container_exporter

  4 files    4 suites   4m 38s ⏱️
196 tests 176 ✅ 20 💤 0 ❌
784 runs  704 ✅ 80 💤 0 ❌

Results for commit 51ed363.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Executor Unit Test Result devs/robbenwang_multi_container_exporter

721 tests   721 ✅  3m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b687a18.

@github-actions GitHub Actions
Copy link

Executor E2E Test Result devs/robbenwang_multi_container_exporter

217 tests   215 ✅  5m 7s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit b687a18.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

SDK CLI Test Result devs/robbenwang_multi_container_exporter

   12 files     12 suites   50m 9s ⏱️
  507 tests   488 ✅ 19 💤 0 ❌
2 028 runs  1 952 ✅ 76 💤 0 ❌

Results for commit 51ed363.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan force-pushed the devs/robbenwang_multi_container_exporter branch from b687a18 to ba763bf Compare March 27, 2024 11:51
@huaiyan huaiyan requested a review from a team as a code owner March 27, 2024 11:51
@github-actions github-actions bot removed promptflow executor The changes related to the execution of the flow labels Mar 27, 2024
@huaiyan huaiyan changed the title WIP: Add start exporter logic for multi-container. Add setup exporter logic as creating executor Mar 27, 2024
@huaiyan huaiyan force-pushed the devs/robbenwang_multi_container_exporter branch from ba763bf to ccdf0cf Compare March 27, 2024 12:03
@huaiyan huaiyan requested a review from a team as a code owner March 27, 2024 12:03
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Mar 27, 2024
@huaiyan huaiyan force-pushed the devs/robbenwang_multi_container_exporter branch from ccdf0cf to 51ed363 Compare March 27, 2024 12:11
@github-actions github-actions bot removed sdk prompt flow SDK promptflow labels Mar 27, 2024
@huaiyan huaiyan requested a review from riddlexu March 28, 2024 02:33
@huaiyan huaiyan merged commit 5b1be09 into main Mar 28, 2024
25 checks passed
@huaiyan huaiyan deleted the devs/robbenwang_multi_container_exporter branch March 28, 2024 03:29
huaiyan pushed a commit that referenced this pull request Mar 28, 2024
Revert "Add setup exporter logic as creating executor (#2480)"
3d2e4eb 
This reverts commit 5b1be09.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thy09 thy09 thy09 approved these changes

@riddlexu riddlexu riddlexu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huaiyan @riddlexu @thy09