Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Add runtime dep of tracing to promptflow._internal #2470

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

riddlexu
Copy link
Contributor

@riddlexu riddlexu commented Mar 25, 2024

Description

When we support tracing API in promptflow-runtime, we have some dependencies of promptflow. We add the dependencies at promptflow._internal.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@riddlexu riddlexu requested a review from a team as a code owner March 25, 2024 10:36
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 25, 2024
@riddlexu riddlexu requested review from huaiyan and thy09 March 25, 2024 10:39
Copy link

github-actions bot commented Mar 25, 2024

SDK CLI Global Config Test Result users/yangtongxu/addRuntimeTraceDepToInternal

3 tests   3 ✅  47s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 3c860a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 25, 2024

promptflow SDK CLI Azure E2E Test Result users/yangtongxu/addRuntimeTraceDepToInternal

  4 files    4 suites   5m 30s ⏱️
190 tests 170 ✅ 20 💤 0 ❌
760 runs  680 ✅ 80 💤 0 ❌

Results for commit 3c860a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 25, 2024

Executor Unit Test Result users/yangtongxu/addRuntimeTraceDepToInternal

721 tests   721 ✅  3m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 3c860a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 25, 2024

Executor E2E Test Result users/yangtongxu/addRuntimeTraceDepToInternal

217 tests   215 ✅  5m 36s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 3c860a8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 25, 2024

SDK CLI Test Result users/yangtongxu/addRuntimeTraceDepToInternal

   12 files     12 suites   48m 13s ⏱️
  496 tests   478 ✅ 18 💤 0 ❌
1 984 runs  1 912 ✅ 72 💤 0 ❌

Results for commit 3c860a8.

♻️ This comment has been updated with latest results.

@riddlexu riddlexu merged commit 161dd1b into main Mar 26, 2024
43 checks passed
@riddlexu riddlexu deleted the users/yangtongxu/addRuntimeTraceDepToInternal branch March 26, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants