Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for start trace behavior. #2455

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Mar 22, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@YingChen1996 YingChen1996 requested a review from a team as a code owner March 22, 2024 11:10
@github-actions github-actions bot added sdk prompt flow SDK promptflow labels Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

SDK CLI Global Config Test Result dev/chenyin/start_trace_message

3 tests   3 ✅  46s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 9daa840.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 22, 2024

promptflow SDK CLI Azure E2E Test Result dev/chenyin/start_trace_message

  4 files    4 suites   5m 31s ⏱️
190 tests 170 ✅ 20 💤 0 ❌
760 runs  680 ✅ 80 💤 0 ❌

Results for commit 9daa840.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 22, 2024

SDK CLI Test Result dev/chenyin/start_trace_message

   12 files     12 suites   48m 27s ⏱️
  496 tests   478 ✅ 18 💤 0 ❌
1 984 runs  1 912 ✅ 72 💤 0 ❌

Results for commit 9daa840.

♻️ This comment has been updated with latest results.

@wangchao1230 wangchao1230 merged commit 83ef48b into main Mar 26, 2024
33 checks passed
@wangchao1230 wangchao1230 deleted the dev/chenyin/start_trace_message branch March 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants