Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for StringIO in case of line execution timeout. #2318

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

huaiyan
Copy link
Contributor

@huaiyan huaiyan commented Mar 12, 2024

Description

This pull request includes a change to the write method in the log_manager.py file. The change adds a check for None to avoid errors when the line execution timeout is reached and all running nodes are cancelled. This is necessary because for synchronous tools running in a worker thread, they can't be stopped and the context won't change in the worker thread as it's a thread-local variable.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@huaiyan huaiyan requested a review from a team as a code owner March 12, 2024 10:35
@github-actions github-actions bot added promptflow executor The changes related to the execution of the flow labels Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Global Config Test Result devs/robbenwang_null_io

2 tests   2 ✅  44s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing unit test result devs/robbenwang_null_io

 4 files   4 suites   22s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing e2e test result devs/robbenwang_null_io

 4 files   4 suites   1m 40s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow SDK CLI Azure E2E Test Result devs/robbenwang_null_io

  4 files    4 suites   3m 49s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor Unit Test Result devs/robbenwang_null_io

754 tests   754 ✅  3m 50s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor E2E Test Result devs/robbenwang_null_io

210 tests   208 ✅  6m 32s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Test Result devs/robbenwang_null_io

   12 files     12 suites   40m 32s ⏱️
  452 tests   434 ✅ 18 💤 0 ❌
1 808 runs  1 736 ✅ 72 💤 0 ❌

Results for commit c81a6c7.

♻️ This comment has been updated with latest results.

@huaiyan huaiyan merged commit 89c3f13 into main Mar 12, 2024
57 checks passed
@huaiyan huaiyan deleted the devs/robbenwang_null_io branch March 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants