-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null check for StringIO in case of line execution timeout. #2318
Conversation
SDK CLI Global Config Test Result devs/robbenwang_null_io2 tests 2 ✅ 44s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
promptflow-tracing unit test result devs/robbenwang_null_io 4 files 4 suites 22s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
promptflow-tracing e2e test result devs/robbenwang_null_io 4 files 4 suites 1m 40s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result devs/robbenwang_null_io 4 files 4 suites 3m 49s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result devs/robbenwang_null_io754 tests 754 ✅ 3m 50s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result devs/robbenwang_null_io210 tests 208 ✅ 6m 32s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result devs/robbenwang_null_io 12 files 12 suites 40m 32s ⏱️ Results for commit c81a6c7. ♻️ This comment has been updated with latest results. |
3ebde77
to
c81a6c7
Compare
Description
This pull request includes a change to the
write
method in thelog_manager.py
file. The change adds a check forNone
to avoid errors when the line execution timeout is reached and all running nodes are cancelled. This is necessary because for synchronous tools running in a worker thread, they can't be stopped and the context won't change in the worker thread as it's a thread-local variable.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines