Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal][SDK] Separate core connection #2315

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

brynn-code
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@brynn-code brynn-code requested review from a team as code owners March 12, 2024 09:48
@github-actions github-actions bot added promptflow-tools promptflow tools code sdk prompt flow SDK promptflow executor The changes related to the execution of the flow labels Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Global Config Test Result brynn/separate-core-connection

2 tests   2 ✅  43s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code force-pushed the brynn/separate-core-connection branch from 553c5b0 to cc066d9 Compare March 12, 2024 09:55
@github-actions github-actions bot removed promptflow-tools promptflow tools code executor The changes related to the execution of the flow labels Mar 12, 2024
@brynn-code brynn-code removed request for a team March 12, 2024 09:56
@brynn-code brynn-code changed the title [Internal] Separate core connection [Internal][SDK] Separate core connection Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing unit test result brynn/separate-core-connection

 4 files   4 suites   22s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow SDK CLI Azure E2E Test Result brynn/separate-core-connection

  4 files    4 suites   3m 47s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing e2e test result brynn/separate-core-connection

 4 files   4 suites   1m 51s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor Unit Test Result brynn/separate-core-connection

754 tests   754 ✅  3m 50s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor E2E Test Result brynn/separate-core-connection

210 tests   208 ✅  9m 30s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Test Result brynn/separate-core-connection

   12 files     12 suites   40m 48s ⏱️
  452 tests   434 ✅ 18 💤 0 ❌
1 808 runs  1 736 ✅ 72 💤 0 ❌

Results for commit ea159ee.

♻️ This comment has been updated with latest results.

Signed-off-by: Brynn Yin <[email protected]>
@brynn-code brynn-code merged commit 84eabc5 into main Mar 12, 2024
57 checks passed
@brynn-code brynn-code deleted the brynn/separate-core-connection branch March 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants