Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal][Executor] Use _kwargs to pass all common kwargs to SpawnedForkProcessManager instead of specifying them explicitly #2312

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Mar 12, 2024

Description

Use _kwargs to pass all common kwargs to SpawnedForkProcessManager instead of instead of specifying them explicitly.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow-tracing unit test result devs/peiwen/refine_process_pool

 4 files   4 suites   22s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 6652b49.

Copy link

SDK CLI Global Config Test Result devs/peiwen/refine_process_pool

2 tests   2 ✅  51s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 6652b49.

Copy link

promptflow-tracing e2e test result devs/peiwen/refine_process_pool

 4 files   4 suites   1m 44s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit 6652b49.

Copy link

promptflow SDK CLI Azure E2E Test Result devs/peiwen/refine_process_pool

  4 files    4 suites   3m 49s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 6652b49.

Copy link

Executor Unit Test Result devs/peiwen/refine_process_pool

754 tests   754 ✅  3m 54s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 6652b49.

Copy link

Executor E2E Test Result devs/peiwen/refine_process_pool

210 tests   208 ✅  6m 9s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 6652b49.

Copy link

SDK CLI Test Result devs/peiwen/refine_process_pool

   12 files     12 suites   40m 34s ⏱️
  451 tests   433 ✅ 18 💤 0 ❌
1 804 runs  1 732 ✅ 72 💤 0 ❌

Results for commit 6652b49.

@PeiwenGaoMS PeiwenGaoMS changed the title [Internal][Executor] Use _kwargs to pass all common kwargs to SpawnedForkProcessManager instead of instead of specifying them explicitly [Internal][Executor] Use _kwargs to pass all common kwargs to SpawnedForkProcessManager instead of specifying them explicitly Mar 12, 2024
@PeiwenGaoMS PeiwenGaoMS merged commit 8c616d3 into main Mar 12, 2024
57 checks passed
@PeiwenGaoMS PeiwenGaoMS deleted the devs/peiwen/refine_process_pool branch March 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants