Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal][Executor] Extract some common constants to promptflow._constants #2303

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented Mar 12, 2024

Description

Extract some constants used by both executor server and sdk/cli to promptflow._constants.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@PeiwenGaoMS PeiwenGaoMS requested review from a team as code owners March 12, 2024 05:38
@github-actions github-actions bot added sdk prompt flow SDK promptflow executor The changes related to the execution of the flow labels Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Global Config Test Result devs/peiwen/extract_common_constants

2 tests   2 ✅  49s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing unit test result devs/peiwen/extract_common_constants

 4 files   4 suites   21s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
16 runs  16 ✅ 0 💤 0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

promptflow-tracing e2e test result devs/peiwen/extract_common_constants

 4 files   4 suites   1m 44s ⏱️
 8 tests  8 ✅ 0 💤 0 ❌
32 runs  32 ✅ 0 💤 0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

elliotzh
elliotzh previously approved these changes Mar 12, 2024
Copy link

github-actions bot commented Mar 12, 2024

promptflow SDK CLI Azure E2E Test Result devs/peiwen/extract_common_constants

  4 files    4 suites   3m 46s ⏱️
168 tests 149 ✅ 19 💤 0 ❌
672 runs  596 ✅ 76 💤 0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor Unit Test Result devs/peiwen/extract_common_constants

754 tests   754 ✅  3m 51s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

Executor E2E Test Result devs/peiwen/extract_common_constants

210 tests   208 ✅  7m 43s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 12, 2024

SDK CLI Test Result devs/peiwen/extract_common_constants

   12 files     12 suites   40m 26s ⏱️
  451 tests   433 ✅ 18 💤 0 ❌
1 804 runs  1 732 ✅ 72 💤 0 ❌

Results for commit 942e4b2.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS changed the title [Internal][Executor] Extract some common constants to promptflow._constants [Internal][Executor] Extract some common constants to promptflow._devkit_constants Mar 12, 2024
elliotzh
elliotzh previously approved these changes Mar 12, 2024
@PeiwenGaoMS PeiwenGaoMS changed the title [Internal][Executor] Extract some common constants to promptflow._devkit_constants [Internal][Executor] Extract some common constants to promptflow._constants Mar 12, 2024
@PeiwenGaoMS PeiwenGaoMS merged commit b2cdec0 into main Mar 12, 2024
57 checks passed
@PeiwenGaoMS PeiwenGaoMS deleted the devs/peiwen/extract_common_constants branch March 12, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
executor The changes related to the execution of the flow promptflow sdk prompt flow SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants