Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example][bugfix] Set environ to make CIs run against production region in PR #1492

Merged
merged 10 commits into from
Dec 15, 2023

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Dec 15, 2023

Description

We observed current examples run against canary region in PR triggered workflows, which results from the wrong environ set inside the workflow, and promptflow does not honor config.json (which works for Azure ML only). This PR targets to fix this by updating the template.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested review from a team as code owners December 15, 2023 03:23
@zhengfeiwang zhengfeiwang merged commit 2580468 into main Dec 15, 2023
44 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/fix-example-pr-region branch December 15, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants