Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete excess UA codes #1356

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Delete excess UA codes #1356

merged 1 commit into from
Dec 1, 2023

Conversation

Stephen1993
Copy link
Contributor

@Stephen1993 Stephen1993 commented Dec 1, 2023

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Dec 1, 2023

SDK CLI Global Config Test Result chenyzhang/fix_ua_code

2 tests   2 ✔️  43s ⏱️
1 suites  0 💤
1 files    0

Results for commit e097104.

Copy link

github-actions bot commented Dec 1, 2023

promptflow SDK CLI Azure E2E Test Result chenyzhang/fix_ua_code

    2 files      2 suites   1m 47s ⏱️
113 tests   95 ✔️ 18 💤 0
226 runs  190 ✔️ 36 💤 0

Results for commit e097104.

Copy link

github-actions bot commented Dec 1, 2023

SDK PFS E2E Test Result chenyzhang/fix_ua_code

  2 files    2 suites   1m 9s ⏱️
15 tests 15 ✔️ 0 💤 0
30 runs  30 ✔️ 0 💤 0

Results for commit e097104.

Copy link

github-actions bot commented Dec 1, 2023

Executor Unit Test Result chenyzhang/fix_ua_code

577 tests   575 ✔️  54s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit e097104.

Copy link

github-actions bot commented Dec 1, 2023

Executor E2E Test Result chenyzhang/fix_ua_code

144 tests   139 ✔️  1m 49s ⏱️
    1 suites      5 💤
    1 files        0

Results for commit e097104.

Copy link

github-actions bot commented Dec 1, 2023

SDK CLI Test Result chenyzhang/fix_ua_code

2 files  2 suites   18s ⏱️
1 tests 1 ✔️ 0 💤 0
2 runs  2 ✔️ 0 💤 0

Results for commit e097104.

@Stephen1993 Stephen1993 merged commit 8f2daed into main Dec 1, 2023
35 checks passed
@Stephen1993 Stephen1993 deleted the chenyzhang/fix_ua_code branch December 1, 2023 10:45
elliotzh pushed a commit that referenced this pull request Dec 1, 2023
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.

(cherry picked from commit 8f2daed)
crazygao pushed a commit that referenced this pull request Dec 4, 2023
# Description

Please add an informative description that covers that changes made by
the pull request and link all relevant issues.

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants