Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable test_collect_package_tools_if_node_source_tool_is_legacy #1345

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

chjinche
Copy link
Contributor

@chjinche chjinche commented Dec 1, 2023

Description

enable test_collect_package_tools_if_node_source_tool_is_legacy

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Dec 1, 2023

SDK CLI Global Config Test Result chjinche/enable_test

2 tests   2 ✔️  48s ⏱️
1 suites  0 💤
1 files    0

Results for commit d55655c.

Copy link

github-actions bot commented Dec 1, 2023

promptflow SDK CLI Azure E2E Test Result chjinche/enable_test

    2 files      2 suites   1m 34s ⏱️
111 tests   93 ✔️ 18 💤 0
222 runs  186 ✔️ 36 💤 0

Results for commit d55655c.

Copy link

github-actions bot commented Dec 1, 2023

Executor Unit Test Result chjinche/enable_test

577 tests   575 ✔️  45s ⏱️
    1 suites      2 💤
    1 files        0

Results for commit d55655c.

Copy link

github-actions bot commented Dec 1, 2023

Executor E2E Test Result chjinche/enable_test

142 tests   137 ✔️  1m 43s ⏱️
    1 suites      5 💤
    1 files        0

Results for commit d55655c.

Copy link

github-actions bot commented Dec 1, 2023

SDK CLI Test Result chjinche/enable_test

2 files  2 suites   18s ⏱️
1 tests 1 ✔️ 0 💤 0
2 runs  2 ✔️ 0 💤 0

Results for commit d55655c.

Copy link

github-actions bot commented Dec 1, 2023

SDK PFS E2E Test Result chjinche/enable_test

  2 files    2 suites   1m 58s ⏱️
15 tests 15 ✔️ 0 💤 0
30 runs  30 ✔️ 0 💤 0

Results for commit d55655c.

@chjinche chjinche merged commit b153618 into main Dec 1, 2023
33 checks passed
@chjinche chjinche deleted the chjinche/enable_test branch December 1, 2023 07:49
crazygao pushed a commit that referenced this pull request Dec 4, 2023
# Description

enable test_collect_package_tools_if_node_source_tool_is_legacy

# All Promptflow Contribution checklist:
- [X] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [X] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [X] Title of the pull request is clear and informative.
- [X] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [X] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants