Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executor] Refine openai metrics calculator to adapt openai v1 #1338

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lumoslnt
Copy link
Contributor

Description

Refine openai metrics calculator to adapt openai v1.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Nov 30, 2023

SDK CLI Global Config Test Result devs/linatang/refine_openai_metrics_calculator

2 tests   2 ✔️  45s ⏱️
1 suites  0 💤
1 files    0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

promptflow SDK CLI Azure E2E Test Result devs/linatang/refine_openai_metrics_calculator

    2 files      2 suites   1m 53s ⏱️
111 tests   93 ✔️ 18 💤 0
222 runs  186 ✔️ 36 💤 0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Executor E2E Test Result devs/linatang/refine_openai_metrics_calculator

142 tests   137 ✔️  1m 43s ⏱️
    1 suites      5 💤
    1 files        0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

SDK CLI Test Result devs/linatang/refine_openai_metrics_calculator

2 files  2 suites   18s ⏱️
1 tests 1 ✔️ 0 💤 0
2 runs  2 ✔️ 0 💤 0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

Executor Unit Test Result devs/linatang/refine_openai_metrics_calculator

577 tests   574 ✔️  48s ⏱️
    1 suites      3 💤
    1 files        0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 30, 2023

SDK PFS E2E Test Result devs/linatang/refine_openai_metrics_calculator

  2 files    2 suites   2m 5s ⏱️
15 tests 15 ✔️ 0 💤 0
30 runs  30 ✔️ 0 💤 0

Results for commit 4877bd3.

♻️ This comment has been updated with latest results.

@lumoslnt lumoslnt force-pushed the devs/linatang/refine_openai_metrics_calculator branch from 7de0719 to f822bd3 Compare December 1, 2023 02:56
@lumoslnt lumoslnt force-pushed the devs/linatang/refine_openai_metrics_calculator branch from f822bd3 to 4877bd3 Compare December 1, 2023 03:11
@thy09 thy09 merged commit a14f55a into main Dec 1, 2023
35 checks passed
@thy09 thy09 deleted the devs/linatang/refine_openai_metrics_calculator branch December 1, 2023 03:58
elliotzh pushed a commit that referenced this pull request Dec 1, 2023
# Description

Refine openai metrics calculator to adapt openai v1.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.

Co-authored-by: Lina Tang <[email protected]>
(cherry picked from commit a14f55a)
elliotzh pushed a commit that referenced this pull request Dec 1, 2023
# Description

Refine openai metrics calculator to adapt openai v1.

# All Promptflow Contribution checklist:
- [ ] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [ ] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [ ] Pull request includes test coverage for the included changes.

Co-authored-by: Lina Tang <[email protected]>
(cherry picked from commit a14f55a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants