-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PromptFlow] Optimize memory computation #1328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hhhilulu
changed the title
Optimize memory computation
[PromptFlow] Optimize memory computation
Nov 30, 2023
Hhhilulu
force-pushed
the
luluzuo/optimize_memory_computation
branch
from
November 30, 2023 10:00
a2c6cf2
to
7f6f3ef
Compare
Hhhilulu
force-pushed
the
luluzuo/optimize_memory_computation
branch
from
December 7, 2023 04:07
658f0c9
to
2c1a1b6
Compare
zzn2
previously approved these changes
Dec 7, 2023
zzn2
reviewed
Dec 7, 2023
src/promptflow/promptflow/executor/_line_execution_process_pool.py
Outdated
Show resolved
Hide resolved
zzn2
approved these changes
Dec 7, 2023
thy09
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize memory computation
The following table summarizes the logic for determining the number of processes and corresponding log messages under different conditions (based on whether fork is used and the setting of the environment variable PF_WORKER_COUNT):
Set process count to 2 by taking the minimum value among the factors of {'default_worker_count': 16, 'row_count': 4, 'estimated_worker_count_based_on_memory_usage': 2}.
Set process count to 2 with the environment variable 'PF_WORKER_COUNT'.
Set process count to 6 with the environment variable 'PF_WORKER_COUNT'.
Warning Message:
The current process count (6) is larger than recommended process count (2) that estimated by system available memory. This may cause memory exhaustion.
Set process count to 4 by taking the minimum value among the factors of {'default_worker_count': 16, 'row_count': 4}.
Set process count to 3 with the environment variable 'PF_WORKER_COUNT'.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines