-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal - remove PAC files from repo (and thus tarball/zipball of actions) and install via nuget #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnilbhalgat
approved these changes
Aug 16, 2023
Are you planning to add Nuget package version to be able to customize packageVersion for new install action? Maybe be default to latest and let customers override it |
petrochuk
approved these changes
Aug 16, 2023
petrochuk
approved these changes
Aug 17, 2023
Yep, added an override argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github's autogenerated "Set up job" step seems to be flakey, specifically for jobs containing our actions here. It usually succeeds, but when it does not, it fails due to timeouts downloading the Action's tarball/zipball corresponding to the selected commitish.
If we do not get a resolution from the GitHub side, our only real option is to reduce the size of the tarball/zipball by removing the largest chunk of it -- the PAC CLI executable and ancillaries.
This PR
actions-install
to install the net48 version of PAC from nuget for Windows hosts or net6.0 dotnet tool version of PAC for Linux hosts, andactions-install
step has not yet been run.This would be a BREAKING CHANGE as no current jobs contain the not-yet-existant
actions-install
action, and thus we should have a major version change to signify that.Example of a job running

actions-install
followed byWho Am I
:Example of a job which runs

actions-install
more than once:Example of a job failing to run

who-am-i
, as it did not runactions-install
first: