Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version, github actions added #60

Merged
merged 22 commits into from
Jun 29, 2020
Merged

Conversation

blackleadsu
Copy link
Contributor

No description provided.


this.element = element;

if (guid) {
this.element.addClass(`visual-${guid}`);
this.element.className += `visual-${guid}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.element.classList.add(visual-${guid});


return $("#item");
element.id = "item";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "item" + guid from https://www.npmjs.com/package/uuidv4

@@ -279,22 +282,18 @@ export function createTouch(x: number, y: number, element: JQuery, id: number =
}

export function clickElement(element: JQuery, ctrlKey: boolean = false): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace clickElement(element: JQuery | HTMLElement

@@ -35,15 +35,13 @@
"devDependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"powerbi-visuals-api": "3.2.0",

@uve uve merged commit e8e414b into microsoft:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants