Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug with dragging cursors #160

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix the bug with dragging cursors #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.5.8
* Fix the bug with dragging cursors

## 2.5.7
* Fix rendering visual when scroll is enabled. Fix scroll arrows not being clicked
* Remove range header font size restrictions
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "powerbi-visuals-timeline",
"version": "2.5.7.0",
"version": "2.5.8.0",
"description": "Timeline slicer is a graphical date range selector used as a filtering component in the report canvas",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions pbiviz.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"visual": {
"name": "Timeline",
"displayName": "Timeline 2.5.7.0",
"displayName": "Timeline 2.5.8.0",
"guid": "Timeline1447991079100",
"visualClassName": "Timeline",
"version": "2.5.7.0",
"version": "2.5.8.0",
"description": "Timeline slicer is a graphical date range selector used as a filtering component in the report canvas",
"supportUrl": "https://community.powerbi.com",
"gitHubUrl": "https://github.com/Microsoft/powerbi-visuals-timeline"
Expand Down
3 changes: 1 addition & 2 deletions src/timeLine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,8 +1141,7 @@ export class Timeline implements powerbiVisualsApi.extensibility.visual.IVisual
}

public onCursorDrag(event: D3DragEvent<any, ICursorDataPoint, ICursorDataPoint>, currentCursor: ICursorDataPoint): void {
const mouseEvent: MouseEvent = event.sourceEvent;
const cursorOverElement: ITimelineCursorOverElement = this.findCursorOverElement(mouseEvent.x);
const cursorOverElement: ITimelineCursorOverElement = this.findCursorOverElement(event.x);

if (!cursorOverElement) {
return;
Expand Down
Loading